Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bank - Payment account and payer fields do not appear after adding bank account #57742

Open
8 tasks done
IuliiaHerets opened this issue Mar 4, 2025 · 4 comments
Open
8 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+030305kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Workflows.
  3. Click Connect bank account.
  4. Click Log into your bank.
  5. Go throught the setup.
  6. On the final step (T&C checkboxes), mark all the checkboxes and click Save and continue.
  7. Close the RHP.

Expected Result:

After the bank account is added, payment account and payer will be shown under "Make or track payments".

Actual Result:

After the bank account is added, payment account and payer are not shown under "Make or track payments".

It requires page refresh for the fields to show up.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6760708_1741082022197.20250304_174511.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 4, 2025
Copy link

melvin-bot bot commented Mar 4, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mkzie2
Copy link
Contributor

mkzie2 commented Mar 4, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

After the bank account is added, payment account and payer are not shown under "Make or track payments".

What is the root cause of that problem?

I think this came from #56932 where the OpenPolicyWorkflowsPage is not re-triggered after closing the RHP. cc @s77rt @abzokhattab

Previously we use useFocusEffect to re-trigger OpenPolicyWorkflowsPage to keep data up to date whenever the page gets re-focused (closing the RHP is one of those cases).

What changes do you think we should make in order to solve the problem?

We can reapply useFocusEffect for this page only to temporarily fix this issue as this flow is a critical important flow.

useFocusEffect(
    useCallback(() => {
        InteractionManager.runAfterInteractions(() => {
            fetchData();
        });
    }, [fetchData]),
);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@s77rt
Copy link
Contributor

s77rt commented Mar 4, 2025

I prefer to not add that use effect. Can wo do one of the following:

  1. Optimistically set the bank info data if possible
  2. Have the BE return onyx data after the bank is added

@melvin-bot melvin-bot bot added the Overdue label Mar 6, 2025
Copy link

melvin-bot bot commented Mar 10, 2025

@bfitzexpensify Eep! 4 days overdue now. Issues have feelings too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Overdue
Projects
None yet
Development

No branches or pull requests

4 participants