Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for #57404] Expensify Card - The back button navigates to wallet page #57461

Open
2 of 8 tasks
IuliiaHerets opened this issue Feb 26, 2025 · 5 comments
Open
2 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.6-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+bm472@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Web, mweb
App Component: Chat Report View

Action Performed:

Precondition -

  • Admin has issued a Virtual card to the member.
  1. Go to https://staging.new.expensify.com
  2. Login as a member
  3. Go to the workspace chat
  4. Click on the Expensify card link
  5. Click on the back button

Expected Result:

The user should be navigated to the workspace chat when clicking the back button.

Actual Result:

After clicking the back button, the user is navigated to the wallet page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6754768_1740559659666.bandicam_2025-02-26_11-36-43-233.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@gijoe0295
Copy link
Contributor

gijoe0295 commented Feb 26, 2025

🚨 Edited by proposal-police: This proposal was edited at 2025-02-26 12:01:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - The back button navigates to wallet page

What is the root cause of that problem?

We explicitly navigate to the wallet page on going back:

onBackButtonPress={() => Navigation.navigate(ROUTES.SETTINGS_WALLET)}

It was intentionally modified to resolve this issue #55278 (comment).

What changes do you think we should make in order to solve the problem?

Use Navigation.goBack instead.

Additionally, we need to implement backTo param for ExpensifyCardPage component and route in case the user refresh the page to prevent the above issue.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

@kadiealexander kadiealexander changed the title Expensify Card - The back button navigates to wallet page [HOLD for #57404] Expensify Card - The back button navigates to wallet page Feb 27, 2025
@kadiealexander kadiealexander added Weekly KSv2 and removed Daily KSv2 labels Feb 27, 2025
@kadiealexander
Copy link
Contributor

Adding a hold to see if this is resolved alongside #57404

@melvin-bot melvin-bot bot added the Overdue label Mar 7, 2025
@kadiealexander
Copy link
Contributor

Still on hold.

@melvin-bot melvin-bot bot removed the Overdue label Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants