Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Chat - Expense preview with "Owes 0,00" appears when deleting all the expenses of a report. #57283

Open
3 of 8 tasks
IuliiaHerets opened this issue Feb 22, 2025 · 11 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 22, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5643822&group_by=cases:section_id&group_order=asc&group_id=295815
Email or phone of affected tester (no customers): ibellicotest+294@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

  1. Open the Expensify app.
  2. Open a workspace chat.
  3. Create at least three expenses and submit them to the workspace.
  4. Open the expense report with the three expenses.
  5. Delele all the expenses.
  6. Return to LHN.
  7. Open another chat.
  8. Navigate to workspace chat again.
  9. Check the expense preview that appears after this action.

Expected Result:

After deleting all the expenses from a report and returning to workspace chat, no expense preview should be visible.

Actual Result:

Expense preview with "Owes 0,00" message is displayed on workspace chat, after deleting all the expenses from a report. This preview appears after navigating to a different chat and returning to workspace conversation.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6750643_1740200828894.0_00.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894112566542583651
  • Upwork Job ID: 1894112566542583651
  • Last Price Increase: 2025-03-10
Issue OwnerCurrent Issue Owner: @eVoloshchak
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 22, 2025
Copy link

melvin-bot bot commented Feb 22, 2025

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@bfitzexpensify bfitzexpensify added the External Added to denote the issue can be worked on by a contributor label Feb 24, 2025
@melvin-bot melvin-bot bot changed the title Chat - Expense preview with "Owes 0,00" appears when deleting all the expenses of a report. [$250] Chat - Expense preview with "Owes 0,00" appears when deleting all the expenses of a report. Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021894112566542583651

@melvin-bot melvin-bot bot added Overdue Help Wanted Apply this label when an issue is open to proposals by contributors labels Feb 24, 2025
@bfitzexpensify bfitzexpensify moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Feb 24, 2025
Copy link

melvin-bot bot commented Feb 24, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 24, 2025
@gurus00
Copy link

gurus00 commented Feb 24, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Chat - Expense preview with "Owes 0,00" appears when deleting all the expenses of a report.

What is the root cause of that problem?

Store for the Workspace owes is not updated correctly after deleting the expenses

What changes do you think we should make in order to solve the problem?

Check and fix store for the workspace owes

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

@eVoloshchak
Copy link
Contributor

@gurus00, thank you for taking an interest in resolving this!

What is the root cause of that problem?
Store for the Workspace owes is not updated correctly after deleting the expenses

That is correct, but why? What is the root cause of this bug? Why is it not updated, which variable/line/function/component is at fault here?

What changes do you think we should make in order to solve the problem?
Check and fix store for the workspace owes

How exactly do we fix it?

You can look at closed PR's, navigate to the issues for those PR's and take a look at proposals there to get a better idea of a valid proposal.
Looking forward to the updated proposal!

Copy link

melvin-bot bot commented Mar 3, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Mar 3, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

@eVoloshchak 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@eVoloshchak
Copy link
Contributor

Not overdue, awaiting for proposals

@melvin-bot melvin-bot bot removed the Overdue label Mar 5, 2025
Copy link

melvin-bot bot commented Mar 8, 2025

@eVoloshchak @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Mar 8, 2025
Copy link

melvin-bot bot commented Mar 10, 2025

@eVoloshchak Eep! 4 days overdue now. Issues have feelings too...

Copy link

melvin-bot bot commented Mar 10, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Overdue
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

4 participants