Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mWeb - VBA - Address suggestion not displayed for company info #5724

Closed
kavimuru opened this issue Oct 8, 2021 · 7 comments
Closed

mWeb - VBA - Address suggestion not displayed for company info #5724

kavimuru opened this issue Oct 8, 2021 · 7 comments
Assignees
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2

Comments

@kavimuru
Copy link

kavimuru commented Oct 8, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Issue found when executing the PR #5643

Action Performed:

  1. Launch the URL and login
  2. Click get started in workspace to add bank account
  3. In the company information page enter random number in the company address field(42 in this case)

Expected Result:

Address suggestion displayed

Actual Result:

No address suggestion displayed

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • Mobile Web

Version Number: 1.1.7.0
Reproducible in staging?: yes
Reproducible in production?: Feature not available
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5270732_IMG_7826.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Oct 8, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Oct 8, 2021

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @Jag96 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@Jag96
Copy link
Contributor

Jag96 commented Oct 8, 2021

@Luke9389 any ideas on this one?

@PrashantMangukiya
Copy link
Contributor

This is CORS issue. It occurs for both localhost:8080 and staging.new.expensify.com Below are screenshots for both. I think this will helpful for engineering team.

staging:
Screenshot 2021-10-08 at 10 17 03 AM

localhost:
Screenshot 2021-10-08 at 10 17 52 AM

@Luke9389
Copy link
Contributor

Luke9389 commented Oct 8, 2021

Hmm, this should be addressed by this PR which is on staging. I wonder if this is sending the request to the production API.

Let's wait for that PR I just linked to hit production to see if this fixes itself.

@Luke9389 Luke9389 assigned Luke9389 and unassigned Jag96 Oct 8, 2021
@Luke9389
Copy link
Contributor

Luke9389 commented Oct 8, 2021

Resolved that the above suggestion is indeed the cause of the issue here: https://expensify.slack.com/archives/C07J32337/p1633718444462700

@Luke9389
Copy link
Contributor

Luke9389 commented Oct 8, 2021

We CP'ed the web proxy PR to production which fixed this issue. Just tested on staging:
Screen Shot 2021-10-08 at 1 29 27 PM

@Luke9389 Luke9389 closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DeployBlockerCash This issue or pull request should block deployment Engineering Hourly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants