[Due for payment 2025-03-11] [Due for payment 2025-03-10] Follow ups to Broken Connection with direct feeds

[mountiny]

Problem

Coming from here:

BUG: We're showing mark as cash button with violation on approved reports. It is correct that we show members the violation on approved/paid reports, but there should be no option to mark as cash in those report states.

And from here https://expensify.slack.com/archives/C07HPDRELLD/p1739989158015199

BUG: Admins don't see this violation on their own expenses, or other employees. They are supposed to see it on both. The expense preview have red dots, but no violation appears when you click in. 🧵

Also coming from here - waiting for copy confirmation

BUG: Violation copy differs for open vs processing reports. Specifically, processing is missing copy about marking as cash. 🧵

Solution

Discussed in the threads, this should be fixable in FE cc @VickyStash

Issue Owner

Current Issue Owner: @OfstadC

[melvin-bot]

Triggered auto assignment to @michaelkwardrop (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.

[VickyStash]

UPD: I haven't had a lot of time on this issue today, but I was able to prepare the accounts for testing and debugging with broken connection violations. Hope to focus tomorrow on bug fixes.

[VickyStash]

Updates:

• I've fixed all of the reported issues. Opened Draft PR, added Test steps and part of the screenshots.
• During testing I've noticed one small issue, waiting for the confirmation about the way it should be resolved - fixed.

I think the PR will be ready for the review on Monday!

[VickyStash]

The PR has been opened for the review.

[VickyStash]

Follow-up PR with the unit test is ready for the review: #57542

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mallenexpensify]

@OfstadC please take over as BZ, thx

[mountiny]

Merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.7-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Follow ups to Broken Connection with direct feeds #57242

If no regressions arise, payment will be issued on 2025-03-10. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @OfstadC @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[OfstadC]

@DylanDylann please complete the BZ checklist prior to payment date. Thank you! 😃

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.8-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Follow-up: add unit test for shouldShowBrokenConnectionViolation function #57542

If no regressions arise, payment will be issued on 2025-03-11. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @DylanDylann requires payment (Needs manual offer from BZ)

[melvin-bot]

@DylanDylann @OfstadC @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[DylanDylann]

@joekaufmanexpensify Do we need to create the regression test on this issue? If yes, could you please help to verify the below steps?

Pre-steps

1. Prepare 2 app accounts.

• Account 1 should be added as an admin to the workspace with company cards set up. The card should be assigned to user 1.
• Account 2 should be added as a member to the same workspace. The card should be assigned to user 2.

The connection should be broken after all.
Receipts to test with: you can find in slack.

Test steps:

1. Login as Account 1 (Admin). Create several scan expenses using the receipts mentioned above. See that after the scanning there are broken connection errors and you see it in the app.
2. Login as Account 2 (Member). Create several scan expenses using the receipts mentioned above. See that after scanning expenses have broken connection errors. Submit one of the expenses, make sure the full message and Mark as cash button are displayed.
3. From Account 1 (Admin): make sure you see broken connection violation errors for expenses created by Account 2. Approve one of the expenses of Account 2.
4. From Account 2 (Member): see that approved expense with broken connection violation error still shows the error message, but without mentioning mark as cash part. Mark as cash button should be hidden.

[joekaufmanexpensify]

We can hold off on a test for now. Applause has no way to break the connection so it wouldn't really be feasible for them.