Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-27] [Navigation] Expense- Destination field is not editable & defaulted to 1:1 DM after coming from amount page #56803

Closed
8 tasks done
mitarachim opened this issue Feb 13, 2025 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Feb 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has a default group workspace.
  1. Go to staging.new.expensify.com
  2. Open FAB > Create expense > Manual.
  3. Enter amount > Next.
  4. Click on the destination field.
  5. Select any user (not workspace).
  6. Click RHP back button.
  7. Click Next.

Expected Result:

Destination field is editable and defaulted to the default group workspace.

Actual Result:

Destination field is not editable and it is defaulted to self DM.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741348_1739405114361.20250213_080100.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2025
@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 13, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@mountiny
Copy link
Contributor

FYI most likely related to https://expensify.slack.com/archives/C01GTK53T8Q/p1739435484596829?thread_ts=1739328522.587109&cid=C01GTK53T8Q and we are discussing and working on solutions for this

@adamgrzybowski
Copy link
Contributor

I can look into this one

@mountiny mountiny added Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2025
@adamgrzybowski
Copy link
Contributor

Okay, I see what is going on here. Tomorrow I will consult this with @WojtekBoman as he stumbled upon something similar. We need to figure out the right solution for such cases.

In short: it's goBack again.

It's even possible to reproduce this on prod if you refresh the page on the confirmation page.

@mountiny
Copy link
Contributor

After looking into this one a bit more, i dont think we have to block the deploy on this as the user can easily complete the action they wanted

@mountiny mountiny changed the title Expense- Destination field is not editable & defaulted to 1:1 DM after coming from amount page [Navigation] Expense- Destination field is not editable & defaulted to 1:1 DM after coming from amount page Feb 13, 2025
@mountiny mountiny assigned mountiny and unassigned robertjchen Feb 13, 2025
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Feb 13, 2025
@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Feb 14, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Feb 14, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Feb 20, 2025
@melvin-bot melvin-bot bot changed the title [Navigation] Expense- Destination field is not editable & defaulted to 1:1 DM after coming from amount page [Due for payment 2025-02-27] [Navigation] Expense- Destination field is not editable & defaulted to 1:1 DM after coming from amount page Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 20, 2025

@shubham1206agra @OfstadC @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny
Copy link
Contributor

No regression tests required and no payment required either this came from the big navigation update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

6 participants