Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [Due for payment 2025-02-25] [Navigation] iOS - FAB - FAB is not responsive after exiting create expense flow #56796

Open
2 of 8 tasks
mitarachim opened this issue Feb 13, 2025 · 27 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review

Comments

@mitarachim
Copy link

mitarachim commented Feb 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Money Requests

Action Performed:

Precondition:

  • Account has a default group workspace.
  1. Launch ND or hybrid app.
  2. Tap FAB > Create expense > Manual.
  3. Enter amount > Next.
  4. Tap app back button twice.
  5. Tap FAB.

Expected Result:

FAB will open.

Actual Result:

FAB is not responsive.

The same issue also happens when opening chat from FAB.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741290_1739399930403.ScreenRecording_02-13-2025_06-35-39_1.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @kadiealexander
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021894208197822729288
  • Upwork Job ID: 1894208197822729288
  • Last Price Increase: 2025-02-25
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@mountiny mountiny removed the DeployBlocker Indicates it should block deploying the API label Feb 13, 2025
@mountiny
Copy link
Contributor

This will be FE issue @nkdengineer @adamgrzybowski and SWM team is looking

@mountiny
Copy link
Contributor

FYI most likely related to https://expensify.slack.com/archives/C01GTK53T8Q/p1739435484596829?thread_ts=1739328522.587109&cid=C01GTK53T8Q and we are discussing and working on solutions for this

@mountiny
Copy link
Contributor

@nkdengineer had a proposal in slack, can you please comment here and raise a pr

@nkdengineer
Copy link
Contributor

@mountiny I'm here.

@mountiny
Copy link
Contributor

The blocker should be fixed, but going to leave this open to discuss if there is better solution that wont force the app to wait for the animation to finish @adamgrzybowski

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Feb 14, 2025
@mountiny mountiny changed the title iOS - FAB - FAB is not responsive after exiting create expense flow [Navigation] iOS - FAB - FAB is not responsive after exiting create expense flow Feb 14, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 18, 2025
@melvin-bot melvin-bot bot added the Overdue label Feb 24, 2025
@kadiealexander kadiealexander added the External Added to denote the issue can be worked on by a contributor label Feb 25, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-25] [Navigation] iOS - FAB - FAB is not responsive after exiting create expense flow [$250] [Due for payment 2025-02-25] [Navigation] iOS - FAB - FAB is not responsive after exiting create expense flow Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021894208197822729288

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 25, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@melvin-bot melvin-bot bot removed the Overdue label Feb 25, 2025
@kadiealexander kadiealexander added Overdue and removed External Added to denote the issue can be worked on by a contributor labels Feb 25, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 25, 2025
@kadiealexander
Copy link
Contributor

@robertjchen @mountiny @nkdengineer was this a regression?

@chintanonweb
Copy link

chintanonweb commented Feb 25, 2025

is the above issue fixed otherwise I have a solution and I can submit a proposal on UW?
Contributor details
Your Expensify account email: chintandhokai97@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01be9514ecd5e4dd18

Copy link

melvin-bot bot commented Feb 25, 2025

📣 @chintanonweb! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@chintanonweb
Copy link

I have a proposal for this issue already, can you review it when you get a chance?
Contributor details
Your Expensify account email: chintandhokai97@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~01be9514ecd5e4dd18

Copy link

melvin-bot bot commented Feb 25, 2025

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@nkdengineer
Copy link
Contributor

@robertjchen @mountiny @nkdengineer was this a regression?

@kadiealexander It's not a regression from my PR, I fixed the blocker.

@ikevin127

This comment has been minimized.

@melvin-bot melvin-bot bot added the Overdue label Feb 28, 2025
@ikevin127
Copy link
Contributor

❌ I'm not able to reproduce in v9.1.7-1 Develop:

Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-02-28.at.07.03.38.mp4

Looks like in OP app version was older and create expense tab navigation looked different, possible it was rolled-back after multiple regressions ? @kadiealexander Not sure what's next for thiss issue - maybe ask QA for retest on latest app version and close if not reproducible.

@nkdengineer
Copy link
Contributor

@ikevin127 This issue is fixed. Just waiting for payment.

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2025
@mountiny
Copy link
Contributor

mountiny commented Mar 2, 2025

@kadiealexander not a regression from @nkdengineer PR

@melvin-bot melvin-bot bot added the Overdue label Mar 5, 2025
@robertjchen robertjchen added the Reviewing Has a PR in review label Mar 6, 2025
@melvin-bot melvin-bot bot removed the Overdue label Mar 6, 2025
@robertjchen
Copy link
Contributor

@kadiealexander are we good to go here? 🙏

@kadiealexander
Copy link
Contributor

Apologies folks, this one slipped through the cracks!

@kadiealexander
Copy link
Contributor

Payments needed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Help Wanted Apply this label when an issue is open to proposals by contributors Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants