[Due for payment 2025-03-05] Mention style highlighting in the query bar doesn't have rounded borders

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.95-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): Expense

Action Performed:

1. Navigate to report search > Expenses
2. Click Search and enter anything to search
3. Observe the mention style highlighting in the query bar

Expected Result:

Mention style highlighting in the query bar should have rounded borders

Actual Result:

Mention style highlighting in the query bar doesn't have rounded borders

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention style highlighting in the query bar doesn't have rounded borders

What is the root cause of that problem?

When users search type: expense, we're consider the expense as the mention-user, and we define the style for mention-user in

App/src/hooks/useMarkdownStyle.ts

Lines 71 to 73 in b0b7709

	mentionUser: {
	color: theme.mentionText,
	backgroundColor: theme.mentionBG,

so there's no borderRadius here.

What changes do you think we should make in order to solve the problem?

1. Add borderRadius: 4 to mentionUser. We can adjust this value

2. Add borderRadius in here, so the borderRadius attribute is applied for the nested span

3. Apply the borderRadius in styleUtil

Note: This way will change the mention-user in chat as well, so I think it's fine for consistency. If we want to applied for search only, we can add the flag to disable it in chat.

We also can consider to add rounded border for mention-report, mention-here, ...

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

No need for unit test, since it's UI issue

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

POC

[289Adam289]

Hi, I am Adam from SWM, an expert agency and I would like to work on this issue. It is related to my recent pr #56243. It will require small change in react-native-live-markdown that will be taken care off.
cc @luacmartins for visibility

[luacmartins]

@289Adam289 let's update the web version of this so it matches the other mentions we have in web

[289Adam289]

This issue requires one change in react-native-live-markdown that is being worked on in Expensify/react-native-live-markdown#617 once the pr is merged I will open pr with a bump and a fix.

[289Adam289]

Hi! My colleague from SWM @JakubKorytko will take over this task. We are still waiting for the react-native-live-markdown pr.

[JakubKorytko]

Hi, I am Jakub from SWM an expert agency and I'd like to work on this issue.

[melvin-bot]

📣 @JakubKorytko! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[luacmartins]

Nice. Assigned you to the issue @JakubKorytko

[Kicu]

Small update on our end - this issue is currently blocked, because the flow that publishes new version of react-native-live-markdown stopped working.
See here: https://github.com/Expensify/react-native-live-markdown/actions/runs/13366802568

So we need this PR Expensify/react-native-live-markdown#617 but it is not yet published :(

here's the thread: https://swmansion.slack.com/archives/C06BDSWLDPB/p1739793644035839

[melvin-bot]

@luacmartins, @MitchExpensify, @JakubKorytko Huh... This is 4 days overdue. Who can take care of this?

[luacmartins]

@Kicu we fixed the issue in react-native-live-markdown and the package is published to npm Expensify/react-native-live-markdown#622 (comment)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.5-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add border radius to auto complete #56866

If no regressions arise, payment will be issued on 2025-03-05. 🎊

For reference, here are some details about the assignees on this issue:

• @JakubKorytko does not require payment (Contractor)

[melvin-bot]

@luacmartins @MitchExpensify @JakubKorytko The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[MitchExpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[MitchExpensify]

Do we need new tests here @JakubKorytko ?

[JakubKorytko]

I don't think it's necessary to create tests for the new border-radius markdown style in the component, since it's only a small visual change.

[Kicu]

☝ I agree

[luacmartins]

Agreed

[eh2077]

@MitchExpensify I helped review this PR #56866. Can you help add payment summary? Thanks

Cc @luacmartins

[luacmartins]

AH yes, sorry about that @eh2077

[luacmartins]

@MitchExpensify seems like we missed payment to @eh2077

[MitchExpensify]

Payment summary:

$250 @eh2077 Paid via NewDot request