Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Using device back navigation on category page directly returns to workspaces list #56500

Closed
2 of 8 tasks
mitarachim opened this issue Feb 7, 2025 · 10 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Feb 7, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.95-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #56203
Email or phone of affected tester (no customers): applausetester+sj9032@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Workspace Settings

Action Performed:

  1. Launch ND or hybrid app.
  2. Go to workspace settings > Categories.
  3. Use back button on device navigation bar or swipe gesture to return to previous page.

Expected Result:

App will return to the previous page which is the workspace settings.

Actual Result:

App returns to workspaces list, which is two steps back.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6735672_1738894510115.1738883832486_Screen_Recording_20250207_071705_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021888958961971435734
  • Upwork Job ID: 1888958961971435734
  • Last Price Increase: 2025-02-10
Issue OwnerCurrent Issue Owner: @ikevin127
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Feb 7, 2025
Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Feb 7, 2025

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Feb 7, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 7, 2025
Copy link
Contributor

github-actions bot commented Feb 7, 2025

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@rohit9625
Copy link
Contributor

rohit9625 commented Feb 7, 2025

I have found a fix for this issue and it is pretty minor. Should I create a proposal or can just comment on the fix?

Edited:
However, it involves modifying a component that is shared among other components. Not sure, if this can affect other part of the app.

@rohit9625
Copy link
Contributor

The issue #56514 also shares the same solution.

Copy link

melvin-bot bot commented Feb 7, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added the Overdue label Feb 10, 2025
@Gonals Gonals added the External Added to denote the issue can be worked on by a contributor label Feb 10, 2025
@melvin-bot melvin-bot bot changed the title Android - Using device back navigation on category page directly returns to workspaces list [$250] Android - Using device back navigation on category page directly returns to workspaces list Feb 10, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021888958961971435734

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 10, 2025
Copy link

melvin-bot bot commented Feb 10, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

@Gonals
Copy link
Contributor

Gonals commented Feb 10, 2025

Seems like the cause is the same as the one for #56514, and we have an accepted proposal there, so closing as duplicate

@Gonals Gonals closed this as completed Feb 10, 2025
@melvin-bot melvin-bot bot removed the Overdue label Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Hourly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants