Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-18] [QOL] Reduce noise from failing builds on main #56292

Closed
roryabraham opened this issue Feb 4, 2025 · 4 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

Problem

When a test or lint fails after a PR is merged to main, we create an issue. However, we always create at least two issues (one for confirmPassingBuild, which just checks that other passed and throws an error if not).

Solution

Don't create issues for confirmPassingBuild job.

@roryabraham roryabraham added Improvement Item broken or needs improvement. Monthly KSv2 labels Feb 4, 2025
@roryabraham roryabraham self-assigned this Feb 4, 2025
@roryabraham
Copy link
Contributor Author

Need to update failureNotifier.yml

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Monthly KSv2 Weekly KSv2 labels Feb 4, 2025
@melvin-bot melvin-bot bot changed the title [QOL] Reduce noise from failing builds on main [Due for payment 2025-02-18] [QOL] Reduce noise from failing builds on main Feb 11, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 11, 2025
Copy link

melvin-bot bot commented Feb 11, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 11, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.95-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-18. 🎊

@roryabraham
Copy link
Contributor Author

This is fixed, no payments due

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Improvement Item broken or needs improvement. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant