Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-05] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly #55601

Closed
1 of 8 tasks
izarutskaya opened this issue Jan 22, 2025 · 39 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@izarutskaya
Copy link

izarutskaya commented Jan 22, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.88-3
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #53845
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Apple iPhone 12 Pro / Safari
App Component: Workspace Settings

Action Performed:

  1. Navigate to https://staging.new.expensify.com/
  2. Log in with a Gmail account that already has a workspace
  3. Navigate to Settings - Workspaces
  4. Tap on the "New workspace" button
  5. Tap on "Default currency" and quickly swipe up

Expected Result:

Currency selector should scroll down.

Actual Result:

Currency selector scrolls to the top when I scroll down quickly.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6719916_1737467985381.RTSM3943.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021882074796298844828
  • Upwork Job ID: 1882074796298844828
  • Last Price Increase: 2025-01-22
  • Automatic offers:
    • ZhenjaHorbach | Reviewer | 105822350
Issue OwnerCurrent Issue Owner: @RachCHopkins
@izarutskaya izarutskaya added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 22, 2025
Copy link

melvin-bot bot commented Jan 22, 2025

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 22, 2025

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link

melvin-bot bot commented Jan 22, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 22, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@allgandalf
Copy link
Contributor

@Krishna2323 will fix this one too as part of #55575

@Beamanator
Copy link
Contributor

Looks like this exists in the prod app, as proven here: https://expensify.slack.com/archives/C01GTK53T8Q/p1737550239414369?thread_ts=1737487302.110339&cid=C01GTK53T8Q

@Beamanator Beamanator added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 22, 2025
@carlosmiceli
Copy link
Contributor

@allgandalf should I assign this issue to @Krishna2323 or no need?

@allgandalf
Copy link
Contributor

naah, this is an exisiting bug on production, so you and @RachCHopkins would need to decide if you want to get this fixed now and if so then open it up for proposals, happy to help as C+ as well to review proposals

@carlosmiceli
Copy link
Contributor

Gotcha, just wasn't sure if the PR that got CPed also fixed this issue, but I guess you're saying that that's not the case in the end, right?

@parasharrajat
Copy link
Member

parasharrajat commented Jan 22, 2025

I can also help.. Let me see root cause as well.

@allgandalf
Copy link
Contributor

but I guess you're saying that that's not the case in the end, right?

BINGOOOO! , you're right

@carlosmiceli carlosmiceli added the External Added to denote the issue can be worked on by a contributor label Jan 22, 2025
@melvin-bot melvin-bot bot changed the title Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly Jan 22, 2025
Copy link

melvin-bot bot commented Jan 22, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021882074796298844828

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 22, 2025
Copy link

melvin-bot bot commented Jan 22, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 24, 2025
@bernhardoj
Copy link
Contributor

@RachCHopkins this is not ready for payment yet.

PR is ready

cc: @ZhenjaHorbach

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 28, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-01-30] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly [HOLD for payment 2025-02-04] [Due for payment 2025-01-30] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 28, 2025
Copy link

melvin-bot bot commented Jan 28, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 28, 2025

@ZhenjaHorbach @RachCHopkins @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@RachCHopkins RachCHopkins changed the title [HOLD for payment 2025-02-04] [Due for payment 2025-01-30] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly [Due for payment 2025-02-04] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly Jan 29, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 29, 2025
@melvin-bot melvin-bot bot changed the title [Due for payment 2025-02-04] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly [HOLD for payment 2025-02-05] [Due for payment 2025-02-04] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.90-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 29, 2025

@ZhenjaHorbach @RachCHopkins @ZhenjaHorbach The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@RachCHopkins RachCHopkins changed the title [HOLD for payment 2025-02-05] [Due for payment 2025-02-04] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly [Due for payment 2025-02-05] [$250] Workspace - mWeb - Currency selector scrolls to the top when I scroll down quickly Jan 29, 2025
@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jan 30, 2025
@RachCHopkins
Copy link
Contributor

@ZhenjaHorbach do you mind doing the checklist, please?

@ZhenjaHorbach
Copy link
Contributor

ZhenjaHorbach commented Feb 4, 2025

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:
  • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

    Link to comment: https://github.com/Expensify/App/pull/39201/files#r1940663083

  • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

    Link to discussion: NA

  • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Test:

  1. Open Settings > Workspace > New workspace
  2. Press the currency field
  3. Quickly scrolls down when the page opens
  4. Verify the page doesn't scroll to the top

Do we agree 👍 or 👎

Copy link

melvin-bot bot commented Feb 5, 2025

@carlosmiceli @RachCHopkins @bernhardoj @ZhenjaHorbach this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@RachCHopkins
Copy link
Contributor

Payment Summary:

  • Contributor: @bernhardoj to be paid $250 via NewDot manual requests
  • Contributor+: @ZhenjaHorbach to be paid $250 via Upwork

Upwork job here

@bernhardoj
Copy link
Contributor

Requested in ND.

@RachCHopkins
Copy link
Contributor

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

@JmillsExpensify
Copy link

$250 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

10 participants