[Due for payment 2025-02-19] [$250] Distance - Distance and Rate field shows "Pending" after distance rate is deleted

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.85-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Mac 15.0 / Chrome
Issue reported by: Applause Internal Team
Device used: applausetester+140105kh@applause.expensifail.com
App Component: Money Requests

Action Performed:

Precondition:

• Workspace has at least two distance rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a distance expense with a distance rate.
4. Go to workspace settings > Distance rates.
5. Delete the distance rate that is used in Step 3.
6. Go back to workspace chat.
7. Go to transaction thread of the distance expense.

Expected Result:

Distance and Rate field will show the correct value after distance rate is deleted (production behavior).

Actual Result:

Distance and Rate field shows "Pending" after distance rate is deleted.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021879305543245512119
• Upwork Job ID: 1879305543245512119
• Last Price Increase: 2025-01-28
• Automatic offers:
• mkzie2 | Contributor | 105976611

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @thienlnam (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[vincdargento]

@MitchExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021879305543245512119

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[thienlnam]

Probably not a blocker, in both scenarios the user still needs to manually update the rate and the error message is correct. It just doesn't show the deleted rate anymore

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance and Rate field shows "Pending" after distance rate is deleted

What is the root cause of that problem?

This is a backend issue. When we remove a rate, it should also be removed from the customUnits of the policy.

• 

As a result, when we handle customMileageRate, it will return undefined because mileageRates does not contain the value of customUnitRateID. This is why the issue occurs.

App/src/libs/DistanceRequestUtils.ts

Line 366 in 9be0b9f

const customMileageRate = customUnitRateID ? mileageRates?.[customUnitRateID] : defaultMileageRate;

What changes do you think we should make in order to solve the problem?

To resolve this issue, we need to update the backend to still return the rates of customUnits, either returning the submitted rate or showing the default value after the rate is removed. Something like that.

App/src/libs/DistanceRequestUtils.ts

Line 366 in 9be0b9f

const customMileageRate = customUnitRateID ? mileageRates?.[customUnitRateID] : defaultMileageRate;

update to:

  const customMileageRate = customUnitRateID ? mileageRates?.[customUnitRateID] ?? defaultMileageRate : defaultMileageRate;

POC:

• 

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We updated the test for this case. If mileageRates?.[customUnitRateID] is undefined, the expected value is defaultMileageRate

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance and Rate field shows "Pending" after distance rate is deleted.

What is the root cause of that problem?

When we delete the distance rate, it no longer exists in policy data. In production, we will display the default rate and the distance accordingly. But why did this happen in staging?

It comes from here

Previously, we always fallback to defaultMileageRate if mileageRates?.[customUnitRateID] is undefined

Now, we only set customMileageRate to defaultMileageRate if customUnitRateID but in our case, customUnitRateID exists and mileageRates?.[customUnitRateID] is undefined.

App/src/libs/DistanceRequestUtils.ts

Line 366 in 7b9e55e

const customMileageRate = customUnitRateID ? mileageRates?.[customUnitRateID] : defaultMileageRate;

Then as expected Pending... appears

App/src/libs/DistanceRequestUtils.ts

Lines 160 to 162 in 9be0b9f

	if (!rate || !currency || !unit) {
	return translate('iou.fieldPending');
	}

What changes do you think we should make in order to solve the problem?

We should update the change as we did before this PR

const customUnitRateID = getRateID(transaction) ?? `${CONST.DEFAULT_NUMBER_ID}`;
const customMileageRate = mileageRates?.[customUnitRateID] ?? defaultMileageRate;

App/src/libs/DistanceRequestUtils.ts

Line 366 in 7b9e55e

const customMileageRate = customUnitRateID ? mileageRates?.[customUnitRateID] : defaultMileageRate;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format.

[melvin-bot]

@Pujan92, @thienlnam, @MitchExpensify Huh... This is 4 days overdue. Who can take care of this?

[MitchExpensify]

@Pujan92 can you check out these proposals as a next step please?

[mkzie2]

@Pujan92 The PR is ready.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.96-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: pending is displayed when deleting the distance rate #56297

If no regressions arise, payment will be issued on 2025-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @Pujan92 requires payment through NewDot Manual Requests
• @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@Pujan92 @MitchExpensify @Pujan92 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[MitchExpensify]

Payment summary:

• $250 @Pujan92 requires payment through NewDot Manual Requests
• $250 @mkzie2 requires payment automatic offer (Contributor)

[melvin-bot]

@Pujan92, @thienlnam, @MitchExpensify, @mkzie2 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[MitchExpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[MitchExpensify]

Can you please complete the BZ steps above @Pujan92 ?

[MitchExpensify]

@mkzie2 is paid with contract ended 👍

[Pujan92]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• [] 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/53852/files#r1969581181

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

1. Go to the workspace chat and create a distance request with a distance rate (not the default distance rate)
2. Delete the distance rate that is selected above
3. Go to the transaction detail and verify that the distance rate changes to the default distance rate.

[melvin-bot]

@MitchExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MitchExpensify]

Thanks @Pujan92

[garrettmknight]

$250 approved for @Pujan92