[HOLD for payment 2025-01-22] [$250] Search - No result when searching for current email address and group chat

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.79-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+8078787@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Search

Action Performed:

Precondition:

• User is logged in to Expensifail account (many contacts).

1. Go to staging.new.expensify.com
2. Open search router.
3. Enter current email address.
4. Close the search router.
5. Open FAB > Start chat.
6. Create a group chat with a few users.
7. Open search router.
8. Enter the group name.

Expected Result:

Self DM and group chat will appear in the search result.

Actual Result:

There is no result when searching for current email address and group chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6702686_1735252101296.20241227_045513.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021872596042643273347
• Upwork Job ID: 1872596042643273347
• Last Price Increase: 2024-12-27
• Automatic offers:
• allgandalf | Reviewer | 105503742

Issue Owner

Current Issue Owner: @laurenreidexpensify

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

@hannojg it looks like this could be related to #51954, can you please have a look? 🙏

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021872596042643273347

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[Beamanator]

Marking external b/c i'm 99% sure this is related to the above linked PR. Also I'm OOO early today so probably won't be able to push this all the way through

[jasperhuangg]

@hannojg Please take a look when you can!

[hannojg]

Sorry, was OOO - looking into this now!!! (feel free to assign to me)

[hannojg]

Okay, I can't reproduce the bug on latest staging or main branch (also searching for the user's own email address is working for me - forgot to record that though)

CleanShot.2024-12-30.at.11.29.53.mp4

Will run a bisect to see if I can find the faulty commit (but then, it seems like its fixed already?)

[hannojg]

Hm, can't reproduce it on the commit for version 9.0.79-0 either where it was originally reproduced 🤔

[hannojg]

CleanShot.2024-12-30.at.11.44.04.mp4

[hannojg]

Not sure, I am not able to reproduce this in any way. Can we please try to reproduce on latest staging @mitarachim ?

(maybe its account specific? do you think I could supportal into your account?)

[Beamanator]

aah interesting, thanks so much for checking @hannojg ! I will try as well, if I also can't reproduce, let's close this out 👍

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[Beamanator]

(reopening while investigating)

[mitarachim]

my slack name : Mita rachim
email : mrachim@applausemail.com

[hannojg]

I can reproduce on Mita's account, looking into this now!

---

Edit 1: Just making first guesses. Mita's account has 12,442 personal details, my high traffic account has 4,582. For the new search we allocate an array buffer, right now it has a fixed size. We already discussed making its size dynamic (based on the input size), and have a follow up issue here. It might be exactly that problem, will try to confirm in a moment.

[hannojg]

Yes, the above assumption is correct. The data for Mita's account is 639,337 chars long, and we currently have a hard limit of 400,000. Will write a fix for this to be dynamic based on this issue which should fix this issue as well:

• Follow up: Investigate dynamic sized search string array buffer for FastSearch #51151

(ie. after increasing the limit to 700,000 I can see the missing chats:)

However, simply increasing it to 700,000 is a bad idea as for most people this will be way too much, taking too much memory + CPU time. I should be able to come up with a proper fix fairly quick, hold on …

[Beamanator]

@hannojg thanks for continuing to look into this, do you think this needs to be a blocker again?

[hannojg]

It only is going to happen for super big accounts, not sure how many real customer accounts have over 12k personal details?

[Beamanator]

Thaaaaaat's very fair 😅 i know we "do" / "will" have mega customers on NewDot, but atm i think unlikelyyyy

[hannojg]

PR is ready for review:

• feat: implement dynamic resizing array buffers #54656

[allgandalf]

PR was merged and is on staging

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.85-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• feat: implement dynamic resizing array buffers #54656

If no regressions arise, payment will be issued on 2025-01-22. 🎊

For reference, here are some details about the assignees on this issue:

• @hannojg does not require payment (Contractor)
• @allgandalf requires payment automatic offer (Reviewer)

[melvin-bot]

@allgandalf @laurenreidexpensify @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[allgandalf]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/51954/files#r1924767255

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• User is logged in to Expensifail account (many contacts).

Test:

1. Open search router. > Enter current email address (expect to find your account)
2. Close the search router.
3. Open FAB > Start chat.
4. Create a group chat with a few users.
5. Open search router > Enter the group name.

Verify that we find the just created group

Do we agree 👍 or 👎

[laurenreidexpensify]

Payment Summary:

C+ reviewer: @allgandalf paid $250 in Upwork 👍