Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Approve button doesn't appear on the preview unless navigated to expense report #54571

Closed
6 of 8 tasks
IuliiaHerets opened this issue Dec 25, 2024 · 17 comments
Closed
6 of 8 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #52537
Email or phone of affected tester (no customers): nathanmulugetatesting+2600@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11 pro/chrome, iPhone 11 / iOS 18.1, Samsung Galaxy A15 5G/Chrome
App Component: Money Requests

Action Performed:

Pre conditions:

  • Create a workspace as an owner
  • Enable workflows and setup an advanced workflow where submitter submits to approver 1 then approver 1 approves to approver 2
  1. Submit an expense as the submitter
  2. Sign in as the approver 1 and approve the expense
  3. Sign in as the approver 2 and open the workspace chat of submitter
  4. Open the expense report

Expected Result:

The approve button appears on the expense preview

Actual Result:

The approve button appears on the expense preview only after navigating into the expense report and navigating back to the workspace chat

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6702032_1735123182988.bandicam_2024-12-25_13-35-52-830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021873767608537982326
  • Upwork Job ID: 1873767608537982326
  • Last Price Increase: 2025-01-06
Issue OwnerCurrent Issue Owner: @Ollyws
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 25, 2024
Copy link

melvin-bot bot commented Dec 25, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Overdue label Dec 30, 2024
@bfitzexpensify bfitzexpensify moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Dec 30, 2024
@bfitzexpensify bfitzexpensify added the External Added to denote the issue can be worked on by a contributor label Dec 30, 2024
@melvin-bot melvin-bot bot changed the title Approve button doesn't appear on the preview unless navigated to expense report [$250] Approve button doesn't appear on the preview unless navigated to expense report Dec 30, 2024
Copy link

melvin-bot bot commented Dec 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021873767608537982326

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Dec 30, 2024
Copy link

melvin-bot bot commented Dec 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@melvin-bot melvin-bot bot removed the Overdue label Dec 30, 2024
Copy link

melvin-bot bot commented Jan 3, 2025

@Ollyws, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Jan 3, 2025
Copy link

melvin-bot bot commented Jan 6, 2025

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Jan 7, 2025

@Ollyws, @bfitzexpensify Still overdue 6 days?! Let's take care of this!

Copy link

melvin-bot bot commented Jan 8, 2025

@Ollyws @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Jan 9, 2025

@Ollyws, @bfitzexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@burczu
Copy link
Contributor

burczu commented Jan 10, 2025

Hi! I'm Bartek from Callstack - expert contributor group. I’d like to work on this issue.

Copy link

melvin-bot bot commented Jan 13, 2025

@Ollyws, @bfitzexpensify 12 days overdue. Walking. Toward. The. Light...

@Ollyws
Copy link
Contributor

Ollyws commented Jan 13, 2025

Go ahead @burczu
🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Jan 13, 2025

Triggered auto assignment to @justinpersaud, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@burczu
Copy link
Contributor

burczu commented Jan 13, 2025

Hey, I have a question regarding reproduction steps:

Does this statement:

Enable workflows and setup an advanced workflow where submitter submits to approver 1 then approver 1 approves to approver 2

Mean these settings?:

Image

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 13, 2025
@burczu
Copy link
Contributor

burczu commented Jan 16, 2025

Hey! I'm unable to reproduce the issue - it looks like it works as expected (the submit button for the second approved shows up once the first approver approves the expense). Could some please help confirming it? Thanks.

@melvin-bot melvin-bot bot added the Overdue label Jan 16, 2025
Copy link

melvin-bot bot commented Jan 17, 2025

@justinpersaud, @burczu, @Ollyws, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

Copy link

melvin-bot bot commented Jan 21, 2025

@justinpersaud, @burczu, @Ollyws, @bfitzexpensify Still overdue 6 days?! Let's take care of this!

@github-project-automation github-project-automation bot moved this from Bugs and Follow Up Issues to Done in [#whatsnext] #expense Jan 21, 2025
@melvin-bot melvin-bot bot removed the Overdue label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
Status: Done
Development

No branches or pull requests

6 participants