Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Track expense - Illustration in the empty state recipient list is top-aligned and not centered #54564

Closed
8 tasks done
IuliiaHerets opened this issue Dec 25, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Dec 25, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.78-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+kh1012033@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

  • Account has at least one workspace.
  1. Go to staging.new.expensify.com
  2. Go to self DM.
  3. Track an expense.
  4. Click Share it with my accountant.
  5. Enter anything on the search field that will return no result.

Expected Result:

Illustration in the empty state should be centered (production behavior).

Actual Result:

Illustration in the empty state is top-aligned.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6702026_1735121258252.20241225_175906.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @anmurali
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Dec 25, 2024
@melvin-bot melvin-bot bot assigned anmurali and MonilBhavsar and unassigned anmurali Dec 25, 2024
Copy link

melvin-bot bot commented Dec 25, 2024

Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Dec 25, 2024

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Dec 25, 2024
Copy link

melvin-bot bot commented Dec 25, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Dec 25, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MonilBhavsar
Copy link
Contributor

Looks like this is introduced by #54231
cc @mkzie2 @Pujan92 if you could please take a look

@Pujan92
Copy link
Contributor

Pujan92 commented Dec 25, 2024

Yes @MonilBhavsar, @mkzie2 plz check this, otherwise I will check this tomorrow. I think we can demote this.

@MonilBhavsar
Copy link
Contributor

MonilBhavsar commented Dec 25, 2024

Thanks! Fine demoting but seems like simple fix to implement. I can take a look in while

@MonilBhavsar
Copy link
Contributor

@Pujan92 if you could please review and test #54577 for the existing and previous issue

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Dec 25, 2024
@jasperhuangg
Copy link
Contributor

This was fixed!

@MonilBhavsar MonilBhavsar removed the DeployBlockerCash This issue or pull request should block deployment label Dec 26, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 26, 2024
@melvin-bot melvin-bot bot changed the title Track expense - Illustration in the empty state recipient list is top-aligned and not centered [HOLD for payment 2025-01-02] Track expense - Illustration in the empty state recipient list is top-aligned and not centered Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-02. 🎊

Copy link

melvin-bot bot commented Dec 26, 2024

@MonilBhavsar @anmurali @MonilBhavsar The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Dec 31, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-01-02] Track expense - Illustration in the empty state recipient list is top-aligned and not centered [HOLD for payment 2025-01-07] [HOLD for payment 2025-01-02] Track expense - Illustration in the empty state recipient list is top-aligned and not centered Dec 31, 2024
Copy link

melvin-bot bot commented Dec 31, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.79-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-07. 🎊

Copy link

melvin-bot bot commented Dec 31, 2024

@MonilBhavsar @anmurali @MonilBhavsar The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants