[HOLD for payment 2025-01-02] Patch failed to be applied but succeeded message is shown

[gedu]

Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1734090304591509

Issue Owner

Current Issue Owner: @abekkala

[fabioh8010]

cc @mountiny

[noumantahir]

Two relevant patch failures I faced today...

• react-native-community/netinfo turbomodule patch
• react-navigattion-core patch

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

@gedu, @abekkala, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mountiny]

@gedu I have seen couple people being slowed down by this, would you be able to prioritize this issue please?

[gedu]

I'm checking how is looking into it

[gedu]

@pac-guerreiro Will take a look at this, @mountiny you can assign the issue to him

[pac-guerreiro]

@gedu @mountiny PR is live now - #54355 😄

[pac-guerreiro]

I'll be away until January 2nd but someone should take care of my work 😄 Happy holidays! 🎉

[pac-guerreiro]

Waiting for @mountiny to review the PR

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA] Patch failed to be applied but succeeded message is shown #54355

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

• @gedu does not require payment (Contractor)

[melvin-bot]

@mountiny @abekkala @gedu The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other: hybrid app setup change

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other: local developemnt

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: This started with the hybrid app setup change

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: No need

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

N/A

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎