[Payment 2025-02-06] [$250] Search- New participant/email is shown as recent chat when found via search

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.73-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5318978
Email or phone of affected tester (no customers): gatantm@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch the app logged in and tap on search
2. Type an email never that you never chatted with

Expected Result:

The new email is shown on top without the recent chats header

Actual Result:

The new email is shown as part of the recent chats section although never talked to it before

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6690166_1733848545538.ScreenRecording_12-10-2024_18-31-12_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021870567347662440875
• Upwork Job ID: 1870567347662440875
• Last Price Increase: 2024-12-28
• Automatic offers:
• FitseTLT | Contributor | 105547307

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-12-10 17:49:25 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search- New participant/email is shown as recent chat when found via search

What is the root cause of that problem?

We are pushing userToInvite to report options list here

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 385 to 387 in 219dabf

	if (filteredOptions.userToInvite) {
	reportOptions.push(filteredOptions.userToInvite);
	}

and displaying it as part of recent chat section here

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 410 to 411 in 219dabf

	const styledRecentReports = recentReportsOptions.map((item) => ({...item, pressableStyle: styles.br2, wrapperStyle: [styles.pr3, styles.pl3]}));
	sections.push({title: translate('search.recentChats'), data: styledRecentReports});

What changes do you think we should make in order to solve the problem?

We should display userToInvite on its own section so remove

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 385 to 387 in 219dabf

	if (filteredOptions.userToInvite) {
	reportOptions.push(filteredOptions.userToInvite);
	}

and push a new section with filteredOptions.userToInvite above here

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 410 to 411 in 219dabf

	const styledRecentReports = recentReportsOptions.map((item) => ({...item, pressableStyle: styles.br2, wrapperStyle: [styles.pr3, styles.pl3]}));
	sections.push({title: translate('search.recentChats'), data: styledRecentReports});

  const [recentReportsOptions, userToInvite] = useMemo(() => {
        if (autocompleteQueryValue.trim() === '') {
            return [searchOptions.recentReports.slice(0, 20)];
        }

        Timing.start(CONST.TIMING.SEARCH_FILTER_OPTIONS);
        const filteredOptions = OptionsListUtils.filterOptions(searchOptions, autocompleteQueryValue, {sortByReportTypeInSearch: true, preferChatroomsOverThreads: true});
        Timing.end(CONST.TIMING.SEARCH_FILTER_OPTIONS);
        const userToInvite = [];
        const reportOptions: OptionData[] = [...filteredOptions.recentReports, ...filteredOptions.personalDetails];
        if (filteredOptions.userToInvite) {
            userToInvite.push(filteredOptions.userToInvite);
        }
        return [reportOptions.slice(0, 20), userToInvite];
    }, [autocompleteQueryValue, searchOptions]);

if (userToInvite?.length) {
        const styledUserToInvite = userToInvite?.map((item) => ({...item, pressableStyle: styles.br2, wrapperStyle: [styles.pr3, styles.pl3]}));

        sections.push({title: undefined, data: styledUserToInvite});
    }

If needed we can use another copy for the title section but it would be aligned with how we are treating userToInvite in WorkspaceInvitePage if we set the title undefined.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

Alternatively we can also remove

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 385 to 387 in 219dabf

	if (filteredOptions.userToInvite) {
	reportOptions.push(filteredOptions.userToInvite);
	}

and then add this line of codes here

if (filteredOptions.userToInvite) {
        const styledUserToInvite = [filteredOptions.userToInvite]?.map((item) => ({...item, pressableStyle: styles.br2, wrapperStyle: [styles.pr3, styles.pl3]}));

        sections.push({title: undefined, data: styledUserToInvite});
    }

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search- New participant/email is shown as a recent chat when found via search

What is the root cause of that problem?

The filteredOptions array includes users who are not invited and are unknown because we didn't specify the canInviteUser and excludeUnknownUsers props when calling the OptionsListUtils.filterOptions function to get the recentReportsOptions.

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 375 to 381 in b27d5c7

	const recentReportsOptions = useMemo(() => {
	if (autocompleteQueryValue.trim() === '') {
	return searchOptions.recentReports.slice(0, 20);
	}
	Timing.start(CONST.TIMING.SEARCH_FILTER_OPTIONS);
	const filteredOptions = OptionsListUtils.filterOptions(searchOptions, autocompleteQueryValue, {sortByReportTypeInSearch: true, preferChatroomsOverThreads: true});

What changes do you think we should make in order to solve the problem?

We should filter out some of the unknown users and users who have not been invited.

We set the canInviteUser and excludeUnknownUsers props to false and true respectively as below.

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Line 381 in b27d5c7

const filteredOptions = OptionsListUtils.filterOptions(searchOptions, autocompleteQueryValue, {sortByReportTypeInSearch: true, preferChatroomsOverThreads: true});

const filteredOptions = OptionsListUtils.filterOptions(searchOptions, autocompleteQueryValue, {sortByReportTypeInSearch: true, preferChatroomsOverThreads: true, canInviteUser: false, excludeUnknownUsers : true});

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can make tests to make sure that the recentReportsOptions have reports where a participant has started interacting with the current user.

So, we will assert if new participant's email is in recentReportsOptions .

[melvin-bot]

@strepanier03 Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@strepanier03 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@strepanier03 Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021870567347662440875

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[strepanier03]

Able to repro this quite easily, moving forward.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The new email is shown as part of the recent chats section although never talked to it before

What is the root cause of that problem?

We push userToInvite option to the recent chat section here

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 385 to 387 in 219dabf

	if (filteredOptions.userToInvite) {
	reportOptions.push(filteredOptions.userToInvite);
	}

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 410 to 411 in 219dabf

	const styledRecentReports = recentReportsOptions.map((item) => ({...item, pressableStyle: styles.br2, wrapperStyle: [styles.pr3, styles.pl3]}));
	sections.push({title: translate('search.recentChats'), data: styledRecentReports});

What changes do you think we should make in order to solve the problem?

We should split the filteredOptions into three sections as we did in NewChatPage here because the user can have the personal detail of other users even never chatted before. Then it doesn't make sense to display the personal detail option in recent chats

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Line 384 in 219dabf

const reportOptions: OptionData[] = [...filteredOptions.recentReports, ...filteredOptions.personalDetails];

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 385 to 387 in 219dabf

	if (filteredOptions.userToInvite) {
	reportOptions.push(filteredOptions.userToInvite);
	}

Another problem is when the search is empty, we only splice the recentReports that can be wrong in the case the recentReports < 20 and we have personal detail options

App/src/components/Search/SearchRouter/SearchRouterList.tsx

Lines 376 to 378 in 219dabf

	if (autocompleteQueryValue.trim() === '') {
	return searchOptions.recentReports.slice(0, 20);
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

[melvin-bot]

@strepanier03 @Ollyws this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@strepanier03, @Ollyws Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@strepanier03, @Ollyws Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@strepanier03, @Ollyws 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[maddylewis]

@Ollyws - can you take a look at the contributor proposals when you have a chance? tysm!

[rlinoz]

New PR is being worked on.

[FitseTLT]

PR raised

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Follow up - Fix - remove recent chats header on Search Router List when searching #55784

If no regressions arise, payment will be issued on 2025-02-06. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment through NewDot Manual Requests
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

@Ollyws @strepanier03 @Ollyws The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[strepanier03]

@Ollyws - I'll check tomorrow for the checklist and reg test steps and then post the payment summary.

@FitseTLT - I paid your contract in Upwork and closed the contract.

[Ollyws]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

1. Launch the app and tap on search
2. type anything
3. Verify the Recent chats header disappears once you type something

Do we agree 👍 or 👎

[melvin-bot]

@rlinoz, @strepanier03, @Ollyws, @FitseTLT Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[FitseTLT]

@strepanier03 Payment overdue

[strepanier03]

@FitseTLT - I paid your contract and closed it last week.

[strepanier03]

@Ollyws payment summary below, feel free to request payment now.

[strepanier03]

Payment Summary

• $250 - @Ollyws paid via Manual Requests
• $250 - @FitseTLT paid via Upwork.

[Ollyws]

Requested in ND.

[garrettmknight]

$250 approved for @Ollyws