Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PAID] Hybrid - Android - Group - Compose box is displayed floating when creating group chat #53185

Closed
1 of 8 tasks
IuliiaHerets opened this issue Nov 27, 2024 · 22 comments
Closed
1 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.67-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5267318&group_by=cases:section_id&group_order=asc&group_id=229067
Email or phone of affected tester (no customers): ibellicotest+41@gmail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the Expensify app.
  2. Tap on the FAB and select "Start Chat"
  3. Add some users to a group.
  4. Tap on "Next"
  5. Tap on "Start Group"
  6. Verify the group is created and that compose box and information message are correctly displayed.

Expected Result:

When a group chat is created, compose box and information message should be displayed in a correct position.

Actual Result:

Compose box and group information message are displayed floating on top of the screen when a new group chat is created.
Issue reproducible on hybrid app only.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6677526_1732661631235.Float.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Nov 27, 2024
Copy link

melvin-bot bot commented Nov 27, 2024

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Nov 27, 2024

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Nov 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@mountiny
Copy link
Contributor

@chrispader @kirillzyusko for 👀 I think we can demote if we are soon to deploy, as this is minor issue that does not block the user completely but it definitely not looking good.

Lets discuss in the slack thread https://expensify.slack.com/archives/C01GTK53T8Q/p1732692440640569

@mountiny mountiny assigned mountiny and unassigned nkuoch Nov 27, 2024
@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Nov 27, 2024
@mountiny
Copy link
Contributor

@staszekscp @mateuuszzzzz could you look into this one please? its not repro in standalone android app.

Demoting as its minor ui issue on one platform not blocking the user

@mountiny mountiny moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Nov 27, 2024
@jnowakow
Copy link
Contributor

@mountiny I'll grab this one

@mountiny
Copy link
Contributor

Thanks, lets go!

@jnowakow
Copy link
Contributor

Not sure if it's the same bug but there is also version when instead of creating group chat opening 1:1 chat breaks display (it can be reproduced in standalone ND)

ND_bug.mov

@jnowakow
Copy link
Contributor

I'm not able to reproduce bug from this issue anymore. I think I saw it at the beginning but now I'm not able to reproduce it anymore. The animation is not very smooth but in the end composer is on its place. I tried release build as well

recording.mov

@mountiny
Copy link
Contributor

@jnowakow Thank you!

Lets keep an eye out for it then

@mountiny mountiny added the Needs Reproduction Reproducible steps needed label Nov 29, 2024
@mountiny mountiny changed the title Hybrid - Android - Group - Compose box is displayed floating when creating group chat [HOLD] Hybrid - Android - Group - Compose box is displayed floating when creating group chat Nov 29, 2024
@melvin-bot melvin-bot bot removed the Overdue label Dec 2, 2024
@mountiny
Copy link
Contributor

mountiny commented Dec 2, 2024

Waiting for reproduction steps

@jnowakow
Copy link
Contributor

jnowakow commented Dec 6, 2024

@mountiny I think I found the reproduction steps and solution for this one while looking at other issue
It's here #53699

@mountiny mountiny added the Reviewing Has a PR in review label Dec 9, 2024
@mountiny mountiny removed the Needs Reproduction Reproducible steps needed label Dec 9, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 26, 2024
@melvin-bot melvin-bot bot changed the title [HOLD] Hybrid - Android - Group - Compose box is displayed floating when creating group chat [HOLD for payment 2025-01-02] [HOLD] Hybrid - Android - Group - Compose box is displayed floating when creating group chat Dec 26, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 26, 2024
Copy link

melvin-bot bot commented Dec 26, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Dec 26, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.78-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-02. 🎊

For reference, here are some details about the assignees on this issue:

  • @jnowakow does not require payment (Contractor)
  • @DylanDylann requires payment (Needs manual offer from BZ)

Copy link

melvin-bot bot commented Dec 26, 2024

@DylanDylann @strepanier03 @DylanDylann The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@garrettmknight garrettmknight moved this from Bugs and Follow Up Issues to Hold for Payment in [#whatsnext] #expense Dec 31, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 2, 2025
Copy link

melvin-bot bot commented Jan 2, 2025

Payment Summary

Upwork Job

BugZero Checklist (@strepanier03)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@strepanier03
Copy link
Contributor

@DylanDylann - I hired you in Upwork, I'll keep an eye out and pay when I see it accepted.

@strepanier03 strepanier03 changed the title [HOLD for payment 2025-01-02] [HOLD] Hybrid - Android - Group - Compose box is displayed floating when creating group chat [Payment 2025-01-02] [HOLD] Hybrid - Android - Group - Compose box is displayed floating when creating group chat Jan 3, 2025
@melvin-bot melvin-bot bot added the Overdue label Jan 6, 2025
Copy link

melvin-bot bot commented Jan 7, 2025

@strepanier03, @mountiny, @jnowakow, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@strepanier03
Copy link
Contributor

I paid the job and closed the contract, thanks @DylanDylann. Closing this out now.

@github-project-automation github-project-automation bot moved this from Hold for Payment to Done in [#whatsnext] #expense Jan 8, 2025
@melvin-bot melvin-bot bot removed Overdue labels Jan 8, 2025
@strepanier03 strepanier03 changed the title [Payment 2025-01-02] [HOLD] Hybrid - Android - Group - Compose box is displayed floating when creating group chat [PAID] Hybrid - Android - Group - Compose box is displayed floating when creating group chat Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
Status: Done
Development

No branches or pull requests

7 participants