Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value of tryNewDot NVP in authenticate response #51958

Closed
Julesssss opened this issue Nov 4, 2024 · 9 comments
Closed

Return value of tryNewDot NVP in authenticate response #51958

Julesssss opened this issue Nov 4, 2024 · 9 comments
Assignees
@Julesssss
Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Nov 4, 2024 •
edited
Loading

Problem

We need to return the tryNewDot NVP value to HybridApp users so that we can route users to the correct app experience. This is required for the TTI app start improvement issue.

The SignInUser command should return an additional field with nvp_tryNewDot, allowing us to determine based on the value of the dismissed key whether to stay on NewDot or transition to OldDot.

Solution

Return the value of tryNewDot dismissed in the authenticate command.

  • SignInUser
  • SignUpUser
@Julesssss Julesssss added Engineering Internal Requires API changes or must be handled by Expensify staff labels Nov 4, 2024
@Julesssss Julesssss self-assigned this Nov 4, 2024
@Julesssss
Copy link
Contributor Author

Notes from my dev env testing:

NewDot user
284 - privateuser@gmail.com

OldDot user
251 - newuser282@gmail.com

empty NVP user
admin@chickens.com

@Julesssss
Copy link
Contributor Author

Data being returned to Web. I might need to work on the Web-E changes next.

@Julesssss
Copy link
Contributor Author

Spent all day on chores, reviews, App deploy No progress.

@melvin-bot melvin-bot bot added the Monthly KSv2 label Nov 11, 2024
@Julesssss Julesssss added Weekly KSv2 and removed Monthly KSv2 labels Nov 11, 2024
@Julesssss
Copy link
Contributor Author

Auth PR: https://github.com/Expensify/Auth/pull/13016

@Julesssss Julesssss added the Reviewing Has a PR in review label Nov 11, 2024
@Julesssss
Copy link
Contributor Author

Auth PR merged, awaiting deployment. I have some Web changes to make in addition.

@Julesssss
Copy link
Contributor Author

Web-E PR in review: https://github.com/Expensify/Web-Expensify/pull/44422

@Julesssss
Copy link
Contributor Author

PRs merged, awaiting deployment

@Julesssss
Copy link
Contributor Author

Auth - done
Web-E on staging, should hit prod today

@Julesssss
Copy link
Contributor Author

Just deployed to prod

@Julesssss Julesssss mentioned this issue Nov 20, 2024
Merged
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Julesssss Julesssss

Labels
Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Julesssss