Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign up - "Link has been resent" message disappears in 5 seconds #5040

Closed
kavimuru opened this issue Sep 2, 2021 · 7 comments
Closed

Sign up - "Link has been resent" message disappears in 5 seconds #5040

kavimuru opened this issue Sep 2, 2021 · 7 comments
Assignees

Comments

@kavimuru
Copy link

kavimuru commented Sep 2, 2021

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Go to https://staging.new.expensify.com
  2. In log in form enter a new email or phone number to create a new user
  3. Click Continue
  4. Click Resend Link

Expected Result:

Message "Link has been re-sent" should be appears for long time

Actual Result:

Message "Link has been re-sent" disappearing after 5 seconds

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
1.0.92-0
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5221109_Recording__322.mp4

Expensify/Expensify Issue URL:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@PrashantMangukiya
Copy link
Contributor

PrashantMangukiya commented Sep 3, 2021

We have to increment timeout duration at line 79. At present is it 5000ms (5 Seconds). We can set to 10000ms (10 Seconds) etc. Or we can also remove timeout statement completely, (i.e. Message remain there and not disappear). whatever engineering team decide to do.

this.successMessageTimer = setTimeout(() => {
this.setState({formSuccess: ''});
}, 5000);

I know External label not set with this issue. I am just giving my suggestion, it will be helpful if handled by someone internally. If this issue considered as external then kindly invite me on Upwork once project posted.

@sketchydroide sketchydroide added the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 3, 2021
@MelvinBot
Copy link

Triggered auto assignment to @zanyrenney (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Sep 3, 2021
@sketchydroide
Copy link
Contributor

I'm not sure on why 5 seconds is not enough, and if it's not then how much should it be, let's go trough triage first, get some more opinions, but at a first glance I see no reason for us to change this

@zanyrenney zanyrenney removed their assignment Sep 3, 2021
@jasperhuangg
Copy link
Contributor

Yup, seems like having it there for 5 seconds is intentional, and I don't think this needs attention right now.

@isagoico
Copy link

isagoico commented Sep 5, 2021

Issue reproducible during KI retests

@sketchydroide
Copy link
Contributor

Ok closing this, this seems intentional, if this becomes an issue we can change it very easily and we can reopen this GH
Thank peoples!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants