Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Web - Dependent tag choices are cleared and actions are repeated when coming online #47113

Closed
1 of 6 tasks
IuliiaHerets opened this issue Aug 8, 2024 · 19 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.18-3
Reproducible in staging?: Y
Reproducible in production?: Y
The issue was found when executing this PR #44995 (comment)
Issue reported by: Applause Internal Team

Action Performed:

  1. ND: Navigate to https://staging.new.expensify.com/
  2. ND: Log in with a New Gmail account
  3. ND: Create a workspace
  4. ND: Switch to OD by navigating to Account settings - Cards & Domains
  5. OD: Navigate to Settings - Workspaces - Group - Created workspace - Tags
  6. OD: Enable "Use multiple levels of tags"
  7. OD: Click on the "Import from Spreadsheet" button
  8. OD: Uncheck "Are these independent tags?"
  9. OD: Upload the attached CSV file
  10. ND: Navigate to the workspace chat
  11. ND: Go offline
  12. ND: Navigate to Composers "+" button - Submit expense - Manual
  13. ND: Input any amount and click on "Next"
  14. ND: Set any value for "Merchant" and submit the expense
  15. ND: Click on the created expense
  16. ND: Click on "State" and select any value
  17. ND: Click on "Region" and select any value
  18. ND: Click on "City" and select any value
  19. ND: Click on "City" again and click on the set value to clear it
  20. ND: Go online

Expected Result:

Changes made while offline should be displayed instantly when coming online.

Actual Result:

Dependent tag choices are cleared and actions taken while offline are slowly repeated when coming online.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6565973_1723145169511!Dependent_tags_tags.csv

Bug6565973_1723144860885.bandicam_2024-08-08_21-03-18-650.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0100368f8944905925
  • Upwork Job ID: 1823053155785640856
  • Last Price Increase: 2024-09-02
Issue OwnerCurrent Issue Owner: @Pujan92
@IuliiaHerets IuliiaHerets added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 8, 2024
Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@IuliiaHerets
Copy link
Author

@miljakljajic FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@melvin-bot melvin-bot bot added the Overdue label Aug 12, 2024
@cead22 cead22 added the External Added to denote the issue can be worked on by a contributor label Aug 12, 2024
@melvin-bot melvin-bot bot changed the title Web - Dependent tag choices are cleared and actions are repeated when coming online [$250] Web - Dependent tag choices are cleared and actions are repeated when coming online Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0100368f8944905925

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 12, 2024
Copy link

melvin-bot bot commented Aug 12, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

@melvin-bot melvin-bot bot removed the Overdue label Aug 12, 2024
@cead22
Copy link
Contributor

cead22 commented Aug 12, 2024

This looks like a legit issue related to offline handling of requests, but not related to #45760 or #44995

Copy link

melvin-bot bot commented Aug 15, 2024

@Pujan92, @miljakljajic Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot melvin-bot bot added the Overdue label Aug 15, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Aug 19, 2024

@Pujan92, @miljakljajic 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@miljakljajic
Copy link
Contributor

Waiting for proposals

Copy link

melvin-bot bot commented Aug 21, 2024

@Pujan92, @miljakljajic 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

Copy link

melvin-bot bot commented Aug 22, 2024

@Pujan92 @miljakljajic this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

Copy link

melvin-bot bot commented Aug 23, 2024

@Pujan92, @miljakljajic 10 days overdue. Is anyone even seeing these? Hello?

Copy link

melvin-bot bot commented Aug 26, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@miljakljajic
Copy link
Contributor

@cead22 am I wrong thinking this could be handled externally?

@cead22
Copy link
Contributor

cead22 commented Aug 28, 2024

I thought the same, but I could see how this might be a tricky issue to fix. Should we close it?

@melvin-bot melvin-bot bot removed the Daily KSv2 label Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

This issue has not been updated in over 14 days. @Pujan92, @miljakljajic eroding to Weekly issue.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Overdue labels Aug 28, 2024
Copy link

melvin-bot bot commented Sep 2, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@miljakljajic
Copy link
Contributor

Yeah, we can close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
No open projects
Status: Done
Development

No branches or pull requests

4 participants