[HOLD for payment on Wednesday, September 8th] IOU - "What's it for?" placeholder is capitalized

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel! https://www.upwork.com/jobs/~01eb24ca989c0c7fb6

---

Action Performed:

1. Click on the global create button
2. Click on request money
3. Set an amount
4. Select another user as an attendee

Expected Result:

What's it for? placeholder is not capitalized.

Actual Result:

"What's it for?" placeholder is capitalized. Looks strange since all placeholders are not in all caps.

Workaround:

None needed, visual issue.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.0.85-6

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

View all open jobs on Upwork

---

From @Julesssss https://expensify.slack.com/archives/C01GTK53T8Q/p1629109910376800

The ‘WHATS’S IT FOR? ’ message looks quite jarring. I think is is supposed to be lowercase?

[MelvinBot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[thesahindia]

Hi there, I think that this can be fixed by changing the translations in en.js and es.js files.
If it's available then I would like to work on this issue.

[MelvinBot]

Triggered auto assignment to @laurenreidexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mananjadhav]

Proposal

Updated the strings in en.js

iOUConfirmationList: {
        whoPaid: 'WHO PAID?', --> 'Who paid?'
        whoWasThere: 'WHO WAS THERE?', ---> 'Who was there?'
        whatsItFor: 'WHAT\'S IT FOR?',  --> 'What\'s it for?'
    }

and es.js

iOUConfirmationList: {
        whoPaid: '¿QUIÉN PAGO?', ---> '¿Quién pago?'
        whoWasThere: '¿QUIÉN ASISTIÓ?', --> '¿Quién asistió?'
        whatsItFor: '¿PARA QUÉ ES?', --> '¿Para Qué es?'
    },

If you notice all the three strings are in caps but the other two are headers in the split money tab.

We could just update the given string or all of them?

[laurenreidexpensify]

https://www.upwork.com/jobs/~01eb24ca989c0c7fb6

[Julesssss]

This is a simple one, so let's go with the first submission.

@thesahindia, would you like to make a start on a PR?

[shawnborton]

While we're at it, can we also add some margin to the top of the "What's it for?" field so there is some more visual separation between the user and the text input? Perhaps @thesahindia you can tag me on your PR and I can help guide you on the spacing from there.

[Julesssss]

Ah, thanks Shawn -- I forgot to add that note to the issue. I don't think we'll need a change to the proposal, as long as @thesahindia is happy

[thesahindia]

@thesahindia, would you like to make a start on a PR?

Sure.
Also let me know if we also want the margin. Adding the comparison below.

1. with marginTop:8
2. without any margin

[shawnborton]

how about mt4 so there is a bit more spacing than what you have on the left?

[thesahindia]

With mt4 :

[shawnborton]

Nice, I think mt4 looks good.

[laurenreidexpensify]

@thesahindia can you pls apply for the job in upwork so I can hire you? Thanks!

[thesahindia]

Thanks @laurenreidexpensify, I have just applied to the job.

[laurenreidexpensify]

QA still on going - I am OOO for payment, so reassigning. When it's deployed pls start clock for payment (which I think is now automated anyways).

[MelvinBot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[adelekennedy]

We're not overdue Melvin - just waiting for this PR to fully merge (following this SO)

[adelekennedy]

@thesahindiahas been paid via Upwork, the contract has been completed and the job is closed!