[HOLD #44269] HIGH: [API] Multiple redundant ReconnectApp calls upon waking client

[muttmuure]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v1.4.82-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @quinthar
Slack conversation: https://expensify.slack.com/archives/C05LX9D6E07/p1718128174597309

Action Performed:

Break down in numbered steps

1. Open NewDot in a chat or in a room
2. Open the Network console
3. Close your laptop lid
4. Wait for 10-15 seconds
5. Open the lid

Expected Result:

Describe what you think should've happened

There should be one ReconnectApp call upon waking the client

Actual Result:

Describe what actually happened

The client queues multiple, successive ReconnectApp calls

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @thienlnam (AutoAssignerNewDotQuality)

[thienlnam]

Will be able to start investigating next week - I have a suspicious this is related to the useNetwork hook. When I open my laptop lid from sleep, I consistently see the offline indicator for a moment and and then will see that it resolves

[melvin-bot]

@thienlnam, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

I've experienced this as well @thienlnam!

[thienlnam]

Been testing a few things that haven't been successful - I still think the issue is around how waking up after sleep the network is temporarily unstable and we shoot off the duplicated call in the beginning

[justinpersaud]

I'm noticing this issue as well this morning. Since I see mentions of network here, I will note that I am tethering off a slow cellular connection.

I did not wake my laptop from sleep or anything here. I just opened NewDot web in production and see it continuously calling ReconnectApp

[adelekennedy]

@thienlnam is there anything that external contributors can help with here? I'm guessing no at the moment

[melvin-bot]

@thienlnam, @adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[thienlnam]

This is actually likely a problem that can be solved externally.

We call ReconnectApp because the network on wake is unstable, but it doesn't seem like we have a mechanism to prevent calling this again even if the passed initialLastUpdateIDAppliedToClient is the same.

I'm not too familiar with the SequentialQueue, so this is perhaps something we could get a contributor to look into in #newdot-quality

[melvin-bot]

@thienlnam @adelekennedy this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[thienlnam]

Discussion here, this likely has the same root cause as this so we'll hold for that

[melvin-bot]

@thienlnam, @adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[adelekennedy]

Still on hold!

[melvin-bot]

@thienlnam, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[adelekennedy]

#44269 is still in progress

[thienlnam]

#44269 is still in progress

[muttmuure]

I think let's close this for focus as the linked issue is the stated root cause.