[$250] Tag - Dependent tag violation message isn't changing to "all tags required"

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Issue found when validating #40741
Version Number: 1.4.82-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

Precondition: Import the attached dependent_tags.csv in OD for a workspace. Enable multi level tags.

1. Navigate to https://staging.new.expensify.com/

2. Log in with an expensifail account

3. Navigate to the workspace chat

4. Start submitting a manual expense

5. Only input the "Merchant" field on the confirmation page

6. Submit the expense

7. Open the expense

8. Click on any of the three missing tags

9. Choose any of the options

Expected Result:

The message should change to "all tags required" for the reported missing tags.

Actual Result:

Dependent tag violation message isn't changing to "all tags required" for the rest of the tags when there are multiple missing tags and one is selected.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6510487_1718181753132!dependent_tags.csv

Bug6510487_1718181753145.bandicam_2024-06-12_10-20-07-860.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013b410860cea8f950
• Upwork Job ID: 1801658425666734007
• Last Price Increase: 2024-08-02

Issue Owner

Current Issue Owner: @yuwenmemon

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kavimuru]

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[kavimuru]

We think this bug might be related to #wave-collect - Release 1

[twisterdotcom]

Also got this: #38682.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013b410860cea8f950

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

@twisterdotcom, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sobitneupane]

Waiting on proposal

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@twisterdotcom, @sobitneupane Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[sobitneupane]

Waiting for proposal

[melvin-bot]

@twisterdotcom @sobitneupane this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[twisterdotcom]

Still waiting on proposals. May be addressed eventually with Control functionality.

[sobitneupane]

Waiting for proposal

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[twisterdotcom]

Still waiting for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[mvtglobally]

Issue is reproducible during KI retests.

1722797814057.missing_tags.mp4

[teneeto]

Hey! I'm Eto Olei from Callstack. I will like to look into this issue. Please assign it to me. Thanks!

[teneeto]

Hi All!,
One little concern here; in trying to reproduce this issue, I'm wondering what expensify account gives the extra tags, as state, region and city after submitting a manual expense.

After submitting an expense with my account, I'm not getting those fields. what am I missing?

[twisterdotcom]

Hold that thought for now @teneeto. I think we may have somebody internally working on Dependent tags soon.

[teneeto]

Alright @twisterdotcom, I'll be glad if you Keep me posted on this. Also, I'm still keeping this on the watch, let me know in any way I can assist. Thanks

[yuwenmemon]

Will look at this as a part of the tags project soon.

[teneeto]

Cool, @yuwenmemon, I'm still here; please let me know if I can come in for any help.

[twisterdotcom]

This is going through the motions internally now.

[yuwenmemon]

I don't get it.... this happens for independent tags too. Are we sure we need this to say "all tags required"? cc @cead22

Kapture.2024-09-17.at.23.16.26.mp4

[twisterdotcom]

Hmm good point, I think given we say "Missing tagName" for each level, this is fine now.

[yuwenmemon]

Sweet - closing!