Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20] Change icon of the hub connections. #43314

Closed
rushatgabhane opened this issue Jun 7, 2024 · 8 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 7, 2024

Slack: https://expensify.slack.com/archives/C02QSAC6BJ8/p1717772156939879

Following these steps: https://github.com/Expensify/App/tree/main/docs#how-to-change-icon-of-a-hub

We have to change the illustration of connections hub for both platforms - Expensify Classic and New Expensify

@rushatgabhane rushatgabhane added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Jun 7, 2024
Copy link

melvin-bot bot commented Jun 7, 2024

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@dannymcclain
Copy link
Contributor

Hey @dylanexpensify, this isn't really a bug, just a quick design update, so I unassigned you and assigned myself.

@rushatgabhane thanks for the guidance!

@dannymcclain
Copy link
Contributor

cc @maddylewis just so you have eyes on this. I should be able to get to it Monday.

@dannymcclain
Copy link
Contributor

PR open ☝️

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title Change icon of the hub connections. [HOLD for payment 2024-06-20] Change icon of the hub connections. Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

Copy link

melvin-bot bot commented Jun 13, 2024

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [] The PR that introduced the bug has been identified. Link to the PR:
  • [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [] Determine if we should create a regression test for this bug.
  • [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@rushatgabhane
Copy link
Member Author

checklist / payment not applicable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants