[$250] Android - Scan - Red dot for uploading corrupt pdf is not shown in preview

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.77
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Open a WS chat
3. Submit a scan expense
4. Enter all details manually
5. Tap on receipt -- 3 dots -- replace
6. Upload a corrupt pdf
7. Navigate to WS chat

Expected Result:

Red dot for uploading corrupt pdf is shown in details page, similarly should be shown in WS chat preview

Actual Result:

Red dot for uploading corrupt pdf is shown in details page but not shown in WS chat preview

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6496640_1717095567344.Screenrecorder-2024-05-30-23-29-38-289_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fa2f0f6f81960fe9
• Upwork Job ID: 1801397664241404221
• Last Price Increase: 2024-06-27

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mallenexpensify]

Asking for pdf file here in #qa

[kavimuru]

PDF used
corrupt_PDF_-2024-04-18 20_47_18.319.pdf

[mallenexpensify]

Thanks @kavimuru ! I'll try to upload tomorrow, we're having site issues meow

[melvin-bot]

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@mallenexpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[mallenexpensify]

@twisterdotcom , can I send this your way since you have a physical device to test with? I'm going to order a pixel 6 or 7 for the bank so folks there can test going forward (cuz there are too many limitations or hoops to jump through with browserstack on bugs like this)

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[twisterdotcom]

Trade ya for #43399

[mallenexpensify]

Deal! Thanks @twisterdotcom

[melvin-bot]

@twisterdotcom this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[twisterdotcom]

This is so niche, but I agree it occurs.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fa2f0f6f81960fe9

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

We see red dot for uploading corrupt pdf is shown in details page but not shown in WS chat preview

What is the root cause of that problem?

When checking report preview errors, it's checking only the action errors

App/src/components/ReportActionItem/ReportPreview.tsx

Line 153 in 2a641d9

ReportUtils.hasActionsWithErrors(iouReportID);

The transaction errors are not checked.

What changes do you think we should make in order to solve the problem?

In

App/src/libs/ReportUtils.ts

Line 6775 in 2a641d9

function hasActionsWithErrors(reportID: string): boolean {

check transaction errors too because a transaction has error means the report action of that transaction also has error

function hasActionsWithErrors(reportID: string): boolean {
    const reportActions = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${reportID}`] ?? {};

    const hasActionError = Object.values(reportActions).some((action) => !isEmptyObject(action.errors));

    if (hasActionError) {
        return true;
    }

    const transactions = TransactionUtils.getAllReportTransactions(reportID);

    const hasTransactionError = transactions.some((transaction) => !isEmptyObject(transaction.errors));

    return hasTransactionError;
}

transaction?.errorFields can also be checked.

Maybe we can separate the transactions check to a hasTransactionsWithErrors.

Looks like similar problem exists in the MoneyRequestPreview

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 108 in 2a641d9

const shouldShowRBR = hasNoticeTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold);

The transaction errors check can be added there also.

What alternative solutions did you explore? (Optional)

On a side note, the issue of the Scan corrupted PDF UX inconsistency in some places in the app will probably be addressed in the issue #43645, using the implementation like here. This issue will still need to be fixed even after the Scan corrupted UX is merged, because the root cause is differnt and there're other transaction errors too that will need to show RBR in MoneyRequestView, ReportPreview

[melvin-bot]

@twisterdotcom, @mkhutornyi Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mkhutornyi]

1 proposal to review

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[twisterdotcom]

Could we get this proposal reviewed, please, @mkhutornyi?

[mkhutornyi]

@truph01 thanks for the proposal. Why does this happen only on android? Or platforms are wrongly tagged in OP?

[truph01]

@mkhutornyi It happens for all platforms.

Or platforms are wrongly tagged in OP?

So yes

[twisterdotcom]

Okay @mkhutornyi is the proposal good enough, or should we wait longer? Going to downgrade to weekly given corrupted PDFs aren't exactly the mainline use case.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Krishna2323]

@mkhutornyi @twisterdotcom, we will prevent uploading corrupt pdf's here .

[melvin-bot]

@twisterdotcom @mkhutornyi this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[twisterdotcom]

Okay, this will be solved with #43645