[HOLD for payment 2024-06-20] [$250] Delay in Accessing Thread After Deleting Parent Message Offline

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1, Open any chat and compose a message.
2, Reply to a message within the chat.
3, Go offline and delete the parent message.
4, Go back online.
5, Exit the thread by clicking the header.
6, Click on the reply notification and observe the delay in entering the thread.

Expected Result:

Immediate access to the thread upon clicking the reply notification when online

Actual Result:

When deleting the parent message offline and re-entering the thread online, there is a delay in accessing the thread.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6481507_1715771313942.thread.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f6c2f1d8999823b2
• Upwork Job ID: 1790744138062864384
• Last Price Increase: 2024-05-15
• Automatic offers:
• Ollyws | Reviewer | 0
• bernhardoj | Contributor | 0

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open Staging deploy checklist to see the list of PRs included in this release, then work quickly on the following:

1. If you find which PR caused the issue/bug, you can reassign it to the person responsible for it.
   • If the author is OOO or won’t get online before the daily deploy is due, you are responsible for finding the best fix/path forward. Don’t hesitate to ask for help!
2. Try to reproduce the issue, if the bug is on production, remove the DeployBlocker label but stay assigned to fix it (or find out which PR broke it to get help from the author).
   • You can adjust the urgency of the issue to better represent the gravity of the bug.
   • If the issue is super low priority, feel free to un-assign yourself.
   • Be careful with PHP warnings, sometimes it is more complex than just adding a null coalescing operator as they might be uncovering some bigger bug.
   • If it was a one-off issue that requires no action (for example, Bedrock was down or it is a duplicated issue), you can close it.

Remember rule #2: Never un-assign yourself from a real DeployBlocker unless you are 100% sure someone else is assigned and will take care of it.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@stephanieelliott FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[lakchote]

Not a blocker (impact is minimal), and can be worked on by external contributors.

Putting the correct labels.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f6c2f1d8999823b2

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[rakhaxor]

Can I try solving it or is it already assigned to somebody else and I can't work on it anymore?

[Julesssss]

We don't yet have a contributor assigned @rakhaxor

[bernhardoj]

PR is ready

cc: @Ollyws

[stephanieelliott]

PR has been approved, just waiting on merge.

[stephanieelliott]

Same as last week, just waiting on merge.

[melvin-bot]

This issue has not been updated in over 15 days. @Julesssss, @Ollyws, @lakchote, @stephanieelliott, @bernhardoj eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[stephanieelliott]

PR was merged to main, should be on staging with next deploy.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix can't interact with deleted parent action after deleting it for a while #42341

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

• @Ollyws requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Ollyws] The PR that introduced the bug has been identified. Link to the PR:
• [@Ollyws] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Ollyws] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Ollyws] Determine if we should create a regression test for this bug.
• [@Ollyws] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Ollyws]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR:

This became reproducible after #40781 but it's not a regression from that PR, I don't think we can really pin this one on any PR.

• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

N/A

• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

N/A

• Determine if we should create a regression test for this bug.

Yes

• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Send 2 messages in any chat
2. Reply to the thread on the message 1
3. Go offline
4. Delete both messages
5. Verify you can press the "N Replies" button of message 1
6. Verify the 2nd message isn't interactable (for example, no hover background)
7. Go online
8. The message 1 will change to [Deleted message]
9. Verify you can press the "N Replies" button immediately

Do we agree 👍 or 👎

[Ollyws]

Requested payment in ND.

[JmillsExpensify]

@stephanieelliott payment summary when you get a chance.

[stephanieelliott]

QA Test created: https://github.com/Expensify/Expensify/issues/406456

Summarizing payment on this issue:

• Contributor: @bernhardoj $250 via Upwork - PAID
• Contributor+: @Ollyws $250 via ND
  Upwork job is here: https://www.upwork.com/jobs/~01f6c2f1d8999823b2

[JmillsExpensify]

$250 approved for @Ollyws

[melvin-bot]

@Julesssss, @Ollyws, @lakchote, @stephanieelliott, @bernhardoj Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

All paid!