Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wave Collect] [Xero] Fix the Organization name placements #41897

Closed
lakchote opened this issue May 9, 2024 · 8 comments
Closed

[Wave Collect] [Xero] Fix the Organization name placements #41897

lakchote opened this issue May 9, 2024 · 8 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2

Comments

@lakchote
Copy link
Contributor

lakchote commented May 9, 2024

Problem 1: The Xero organization name is missing from the page header of Advanced.

image

Take a look at Import by comparison:

image

Problem 2: With the NetSuite connection design, we’re adding the organization to each of the next sub-pages. Example from NetSuite below:
image

Context link: https://expensify.slack.com/archives/C036QM0SLJK/p1715159992727079?thread_ts=1713799302.291019&cid=C036QM0SLJK

@lakchote lakchote self-assigned this May 9, 2024
@lakchote lakchote moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 9, 2024
@lakchote lakchote added the Daily KSv2 label May 9, 2024
@trjExpensify trjExpensify added the Bug Something is broken. Auto assigns a BugZero manager. label May 9, 2024
Copy link

melvin-bot bot commented May 9, 2024

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mananjadhav
Copy link
Collaborator

I can help with the review once this is ready.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 10, 2024
@trjExpensify
Copy link
Contributor

PR hit staging yesterday.

@lakchote
Copy link
Contributor Author

Assigning @mananjadhav as he'll need to be paid for the C+ review of the linked PR once this hits production and the 7 day regression period passes.

@rushatgabhane
Copy link
Member

no separate pay required. payment will be handled centrally

@jliexpensify
Copy link
Contributor

Does anyone need a payment summary specifically written for this GH? @rushatgabhane @mananjadhav

@trjExpensify
Copy link
Contributor

Nope, it just needs to sit out the regression period and then we can close it.

@mananjadhav
Copy link
Collaborator

@jliexpensify This one is good to close now.

@github-project-automation github-project-automation bot moved this from Release 1.5: XeroCon 2024 (June 12th) to Done in [#whatsnext] #wave-collect Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Reviewing Has a PR in review Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants