Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Android - Send invoice - In conversation page, transaction preview shown briefly and disappeared #41839

Closed
2 of 6 tasks
lanitochka17 opened this issue May 8, 2024 · 13 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented May 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.71
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch app
  2. Tap fab --- send invoice
  3. Enter an amount and tap next
  4. Select a contact
  5. Tap send invoice

Expected Result:

In send invoice conversation page, transaction preview must not be shown briefly and disappeared

Actual Result:

In send invoice conversation page, transaction preview shown briefly and disappeared

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6474549_1715154246422.ybb.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014e2c68306bbf442b
  • Upwork Job ID: 1788235320335278080
  • Last Price Increase: 2024-05-08
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@lschurr FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@lschurr lschurr added the External Added to denote the issue can be worked on by a contributor label May 8, 2024
@melvin-bot melvin-bot bot changed the title Android - Send invoice - In conversation page, transaction preview shown briefly and disappeared [$250] Android - Send invoice - In conversation page, transaction preview shown briefly and disappeared May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Job added to Upwork: https://www.upwork.com/jobs/~014e2c68306bbf442b

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 8, 2024
Copy link

melvin-bot bot commented May 8, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@james-tindal
Copy link

Root cause

In the server's response to SendInvoice, the disappearing ReportAction has an empty message.

Solution

Server

reportAction.message[0].html and reportAction.message[0].text should be non-empty strings.

Front-end

This can be worked-around by adding the message to the successData on the front-end.

@cristipaval cristipaval self-assigned this May 10, 2024
@cristipaval cristipaval added the Internal Requires API changes or must be handled by Expensify staff label May 10, 2024
Copy link

melvin-bot bot commented May 10, 2024

Current assignee @dukenv0307 is eligible for the Internal assigner, not assigning anyone new.

@cristipaval cristipaval removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels May 10, 2024
@cristipaval
Copy link
Contributor

We knew about this issue and we're working internally on it

Copy link

melvin-bot bot commented May 13, 2024

@cristipaval, @lschurr, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label May 13, 2024
@lschurr
Copy link
Contributor

lschurr commented May 13, 2024

Any update @cristipaval?

@cristipaval
Copy link
Contributor

^fix PR up

@melvin-bot melvin-bot bot removed the Overdue label May 14, 2024
@cristipaval cristipaval added the Reviewing Has a PR in review label May 14, 2024
Copy link

melvin-bot bot commented May 21, 2024

@cristipaval, @lschurr, @dukenv0307 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@cristipaval
Copy link
Contributor

The fix PR hit production. No payments due for this issue.

@github-project-automation github-project-automation bot moved this from Critical to Done in [#whatsnext] #billpay May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
Status: Done
Development

No branches or pull requests

5 participants