Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Threads - Hmm... it's not here page is shown when using the link of a message #39737

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 5, 2024 · 17 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.60-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife+adf41@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Start a chat/Go to any chat
  2. Send a message
  3. Write click on the message body and click on copy ink
  4. Create a thread on the message sent
  5. Paste the Link copied on the thread created
  6. Click on the link pasted
    Notice that when clicking the link it takes you back to the Parent Conversation highlighting the parent message
  7. Now go to the same thread, right-click on the Parent message that is in the thread, and Copy link
  8. Paste the copied link to the composer and send it
  9. Click on the link pasted. Notice that Hmm... it's not here page is shown
    Note: Using the link of the Parent message that is in the thread anywhere results in Hmm... it's not here page, being displayed

Expected Result:

Able to use the link of the Parent message that is in the thread

Actual Result:

Using the link of the Parent message, that is in the thread, anywhere results in Hmm... it's not here page, being displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6438138_1712245439074.Issue_on_Copy_Link.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0100f8db9a0c05cca8
  • Upwork Job ID: 1779873465345101824
  • Last Price Increase: 2024-04-15
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

@muttmuure FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp

@nkdengineer
Copy link
Contributor

nkdengineer commented Apr 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

  • Threads - Hmm... it's not here page is shown when using the link of a message

What is the root cause of that problem?

  • In here, the reportID points to the current thread report ID, not a parent reportID, that leads to the report action link is not correct, so the "It's not here" is displayed in this case.

What changes do you think we should make in order to solve the problem?

  • We can update this to:
                const report = ReportUtils.getReport(reportID);
                const parentReportActionID = report.parentReportActionID;
                let targetReportID = reportID;

                if (parentReportActionID && reportActionID === parentReportActionID) {
                    targetReportID = report.parentReportID;
                }
                Clipboard.setString(`${environmentURL}/r/${targetReportID}/${reportActionID}`);

so, if the report action is parent report action, use the parent report ID instead of current report ID

What alternative solutions did you explore? (Optional)

  • NA

@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
Copy link

melvin-bot bot commented Apr 8, 2024

@muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@muttmuure
Copy link
Contributor

Handling tomorrow

@melvin-bot melvin-bot bot removed the Overdue label Apr 9, 2024
@muttmuure muttmuure added the External Added to denote the issue can be worked on by a contributor label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Apr 10, 2024
Copy link

melvin-bot bot commented Apr 10, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #vip-vsb Apr 10, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 12, 2024
@muttmuure muttmuure added External Added to denote the issue can be worked on by a contributor and removed External Added to denote the issue can be worked on by a contributor labels Apr 15, 2024
@melvin-bot melvin-bot bot changed the title Threads - Hmm... it's not here page is shown when using the link of a message [$250] Threads - Hmm... it's not here page is shown when using the link of a message Apr 15, 2024
Copy link

melvin-bot bot commented Apr 15, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0100f8db9a0c05cca8

Copy link

melvin-bot bot commented Apr 15, 2024

Current assignee @akinwale is eligible for the External assigner, not assigning anyone new.

@FitseTLT
Copy link
Contributor

This is dupe

@muttmuure
Copy link
Contributor

Closing dupe

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@github-project-automation github-project-automation bot moved this from MEDIUM to CRITICAL in [#whatsnext] #vip-vsb Apr 15, 2024
@nkdengineer
Copy link
Contributor

nkdengineer commented Apr 15, 2024

@muttmuure I do not think it is a dupe of #36057 because currently, I cannot reproduce that bug

@FitseTLT
Copy link
Contributor

@muttmuure I do not think it is a dupe of #36057 because currently, I cannot reproduce that bug

If you can't reproduce that bug then you can't reproduce this one. Both are the same issues and hence reproducible.

@nkdengineer
Copy link
Contributor

I can reproduce this one in staging. Please correct me if I miss any step:

Screen.Recording.2024-04-15.at.22.01.04.mov

@FitseTLT
Copy link
Contributor

@nkdengineer It is the Actual Result that is confusing you, it is because of the time difference between the creation of the two issues but the expected behaviour is same for both; the parent message highlighted on the current thread same as comment linking behaves in all other cases.

@nkdengineer
Copy link
Contributor

@FitseTLT Thanks for your information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

5 participants