Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag - Tag selection cleared if selected before missing tag violation appears #39498

Closed
1 of 6 tasks
lanitochka17 opened this issue Apr 3, 2024 · 4 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Apr 3, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.59-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #38881

Action Performed:

precondition: user is an employee of the collect policy in OD, as an admin upload a set of independent tags in OD

  1. Go to https://staging.new.expensify.com/
    and log in as an employee
  2. Open the workspace chat and request money
  3. In OD change the order of tags
  4. In ND create another money request
  5. Open the transaction chat
  6. Before the "Missing tag" violation appears, select tags

Expected Result:

The "Missing tag" violation is not displayed for tags that have already been selected

Actual Result:

After the "Missing tag" violation appears, the previous tag selection gets cleared out

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6435871_1712080359222.Recording__372.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Apr 3, 2024
Copy link

melvin-bot bot commented Apr 3, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@lanitochka17
Copy link
Author

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@joekaufmanexpensify
Copy link
Contributor

This only happens if you both change the order of the tags in OldDot AND very quickly after doing that try and create a report in NewDot on the policy. If you wait like ~1 minute after changing the order of the tags, i can't reproduce. That said, this is very niche, and doesn't seem like worth prioritizing. Let's see if this impacts anyone before deciding to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

2 participants