[HOLD for payment 2024-04-09] [$50] [Simplified Collect][Members] Transfer owner - Typing error in "You're now the owner if this workspace"

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.57-0
Reproducible in staging?: y
Reproducible in production?: n
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an admin of a Collect workspace, but not an owner.

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > Collect workspace.
3. Go to Members.
4. Click on the owner in the list.
5. Click Transfer owner.
6. Go through the steps.

Expected Result:

The final step shows "You're now the owner of this workspace".

Actual Result:

The final step shows "You're now the owner if this workspace".

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6428619_1711540654857.typo.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e7f705da068a3f67
• Upwork Job ID: 1773004791501500416
• Last Price Increase: 2024-03-27

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[ZhenjaHorbach]

Looks like regression from this PR
#37869

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transfer owner - Typing error in "You're now the owner if this workspace"

What is the root cause of that problem?

The main problem with issue is that we use incorrect text

What changes do you think we should make in order to solve the problem?

To fix this issue we can update text here

App/src/languages/en.ts

Line 2128 in 291fec5

successDescription: "You're now the owner if this workspace.",

If the translator is not lying, we have a correct translation in Spanish

Additional information:
I checked all new translations using grammary, and found this ( But it looks optional)

What alternative solutions did you explore? (Optional)

NA

[kbecciv]

We think that this bug might be related to #wave-control

[ghost]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Transfer owner - Typing error in "You're now the owner if this workspace"

What is the root cause of that problem?

Here in en.ts file :

App/src/languages/en.ts

Line 2139 in cd18bef

successDescription: "You're now the owner if this workspace.",

as well as in es.ts file :

App/src/languages/es.ts

Line 2169 in cd18bef

successDescription: 'Ahora eres el propietario de este espacio de trabajo.',

the text is wrong, You're now the owner if this workspace.

What changes do you think we should make in order to solve the problem?

We need to update it from You're now the owner if this workspace. to You're now the owner of this workspace.

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[flodnv]

cc @luacmartins

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e7f705da068a3f67

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

❌ There was an error making the offer to @fedirjh for the Reviewer role. The BZ member will need to manually hire the contributor.

[melvin-bot]

❌ There was an error making the offer to @ZhenjaHorbach for the Contributor role. The BZ member will need to manually hire the contributor.

[melvin-bot]

Upwork job price has been updated to $25

[flodnv]

@ZhenjaHorbach go ahead and submit the PR

[luacmartins]

I'm gonna demote this to NAB given that these pages are not available to users yet.

[flodnv]

@strepanier03 the only payment needed here is $50 to @ZhenjaHorbach. No C+, no regressions.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Transfer owner - Typing error in "You're now the owner if this workspace" #39073

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@flodnv] The PR that introduced the bug has been identified. Link to the PR:
• [@flodnv] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@flodnv] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[strepanier03]

@dylanexpensify - I'm going to be out of the office when the payment hold is lifted. All that's needed is payment on the 9th (I'll be back the 12th). I handled the manual hiring and we're just waiting for the contributor to accept.

@ZhenjaHorbach - I've hired you to the job in Upwork, please accept that.

[ZhenjaHorbach]

@dylanexpensify - I'm going to be out of the office when the payment hold is lifted. All that's needed is payment on the 9th (I'll be back the 12th). I handled the manual hiring and we're just waiting for the contributor to accept.

@ZhenjaHorbach - I've hired you to the job in Upwork, please accept that.

Done )

[dylanexpensify]

Payment summary:

• Contributor: @ZhenjaHorbach $50

Please apply!

[dylanexpensify]

yo! All done!