[HOLD App#37783] [$250] Multilevel tags - Tag name in selection list shows the other tag name in confirmation page

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v.1.4.53-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4429997
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• User is an employee of Collect workspace.
• The Collect workspace has dependant multilevel tag set up
• The multilevel tag is as follow:
  First level: State
  Second level: Region

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Begin manual request flow.
4. In confirmation page, click Show more.
5. Click the first level tag: State.
6. Click the second level tag: Region.

Expected Result:

The tag name in RHP will show the correct tag name.

Actual Result:

The tag name in RHP shows the incorrect tag name.
In Step 5, it shows Region when it is State.
In Step 6, it shows State when it is Region.
Different from issue 37783 because this issue occurs in confirmation page only in this build v.1.4.53-2

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6417475_1710758436207.20240318_183255.mp4

Bug6417475_1710758436175!Dependent.-.Multi.Level.tags.NEW.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015c4cfe611e62ddef
• Upwork Job ID: 1769707891827982336
• Last Price Increase: 2024-03-18

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Current assignee @puneetlath is eligible for the Engineering assigner, not assigning anyone new.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to the #collect project.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015c4cfe611e62ddef

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Upwork job price has been updated to $250

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Multilevel tags - Tag name in selection list shows the other tag name in confirmation page

What is the root cause of that problem?

We order it with orderWeight to get tag list here

App/src/libs/PolicyUtils.ts

Lines 190 to 191 in 28cfc14

	.sort((tagA, tagB) => tagA.orderWeight - tagB.orderWeight);
	}

But we do not order before we get the tag name using the unordered list here

App/src/pages/iou/request/step/IOURequestStepTag.js

Lines 95 to 96 in 28cfc14

	const policyTagListName = PolicyUtils.getTagListName(policyTags, tagIndex);

What changes do you think we should make in order to solve the problem?

We should order the policyTags using orderWeight as in here

App/src/libs/PolicyUtils.ts

Lines 190 to 191 in 28cfc14

	.sort((tagA, tagB) => tagA.orderWeight - tagB.orderWeight);
	}

and pass it here

App/src/pages/iou/request/step/IOURequestStepTag.js

Lines 95 to 96 in 28cfc14

	const policyTagListName = PolicyUtils.getTagListName(policyTags, tagIndex);

What alternative solutions did you explore? (Optional)

[tienifr]

Dupe of #37783, same root cause, this will be fixed in #37783

[mountiny]

Thanks! Odd this came as a blocker now. I will demote this also because the multilevel tags are not yet used by customers in NewDot and put on hold for that linked issue

[puneetlath]

Still on hold.

[puneetlath]

Still on hold.

[puneetlath]

Still on hold.

[puneetlath]

Still on hold.

[puneetlath]

Looks like the other issue is fixed on staging. Asked for a re-test here: https://expensify.slack.com/archives/C9YU7BX5M/p1714410750527969

[kbecciv]

Unable to reproduce it, build 1.4.67.2

bandicam.2024-04-29.21-37-07-452.mp4

[puneetlath]

Great, closing out!