Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - The share code and status icons are too close to the browser address bar #38366

Closed
2 of 6 tasks
lanitochka17 opened this issue Mar 15, 2024 · 7 comments
Closed
2 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Mar 15, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.4.52-5
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/
    and log in
  2. Tap the account settings on the navigation bar

Expected Result:

There is some padding above the share code and status icons

Actual Result:

The share code and status icons are too close to the browser address bar (the top of the icons are cut off)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

viber_image_2024-03-14_20-21-28-108 (1)

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Mar 15, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 15, 2024

Triggered auto assignment to @robertjchen (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@lanitochka17
Copy link
Author

We think that this bug might be related to #vip-vsp
CC @quinthar

@robertjchen robertjchen removed the DeployBlockerCash This issue or pull request should block deployment label Mar 15, 2024
@luacmartins
Copy link
Contributor

Maybe it was caused by this CP - #38343

@luacmartins
Copy link
Contributor

Oh nvm, I think that's something else since that CP only changed the workspace initial page.

@jeremy-croff
Copy link
Contributor

@luacmartins this commit in latest main has the fix already but it's not in staging:
5c9736e

@robertjchen
Copy link
Contributor

Got it! Let's close this out for now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants