Distance - Distance rate changes to personal expense distance rate after editing distance

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.52-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Create a new workspace.
3. Go to workspace chat.
4. Create a distance request.
5. Go to distance request details page.
6. Note that distance rate.
7. Click Distance.
8. Edit the distance and save it.

Expected Result:

The distance rate for the new distance will follow the workspace distance rate.

Actual Result:

The distance rate for the new distance follows the personal expense distance rate after changing distance.
If the distance request is edited on Collect workspace as employee, there will be a red dot next to transaction thread in LHN.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6413249_1710405338008.20240314_163248.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think that this bug might be related to #wave-collect - Release 1
CC @trjExpensify

[puneetlath]

Looks like this is a back-end issue. @neil-marcellini I see you recently have been working on P2P distance. Any ideas about the cause?

[trjExpensify]

If it's P2P Distance related that project is moving to #vip-vsb. 👍

[puneetlath]

It actually affects workspace requests :(

[trjExpensify]

Yeah, being discussed here: https://expensify.slack.com/archives/C07J32337/p1710440479773439

[nkuoch]

A fix has been sent to Web staging. Can you please re-test?

[neil-marcellini]

Note that this bug also only occurs if your personal workspace and workspace requested from have different reporting currencies. The easiest way to reproduce is to change the currency of the workspace to something other than USD.

[puneetlath]

Just tested and it looks like it's working properly now. Closing this out!