[PAID] [$500] Chat - Single line code block is hidden if user insert an emoji into it

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): fischer9966@gmail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal Team

Action Performed:

1. Open App or go to staging.new.expensify.com
2. Login with any account
3. Open any chat
4. Post message with single line code block with any text
5. Edit the block by adding emoji to it
6. Save message

Expected Result:

Edited single line code block appears in the chat with all content including the added emoji

Actual Result:

Edited single line code block is hidden if user insert an emoji into it. But this block is still editable.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6402486_1709627179172.iOS-inline-block-hidden-if-emoji-added.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016316c465e62d2eab
• Upwork Job ID: 1764992662563991552
• Last Price Increase: 2024-03-05

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@nkuoch I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[nkuoch]

I think it can be external yes.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016316c465e62d2eab

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[shubham1206agra]

Offending PR #35838

[roryabraham]

should be fixed by #37778 in 1.4.47-3

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[kavimuru]

Issue is not reproducible anymore.

RPReplay_Final1709667865.MP4

[Akintunde102]

I figured out what the issue is.

It's here:InlineCodeBlock

The InlineCodeBlock component treats all incoming code as though it will always be text and nothing else, thereby making it impossible for react-native-render-html to make use of the EmojiRenderer and possibly any other tag-based HTML renderer.

My approach is to remove the strict approach and allow the InlineCodeBlock process more than just text. It works.

[Akintunde102]

Guess it's fixed already...

[roryabraham]

great, I think we would be ready to close this out, @strepanier03 just need to pay @mkhutornyi for their review of the revert. Because it was a revert, I don't think it makes sense to wait the 7 days for the regression period. We should just pay it out today

[strepanier03]

Missed this comment, sorry about that. Working on payment now.

[strepanier03]

@mkhutornyi - I sent you an offer for a job, I'll check to try to pay it tomorrow.

[strepanier03]

All paid, closing.