Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BA - User can continue the flow with wrong account number, then error appears on other page #37730

Closed
2 of 6 tasks
izarutskaya opened this issue Mar 5, 2024 · 14 comments
Closed
2 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review

Comments

@izarutskaya
Copy link

izarutskaya commented Mar 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v1.4.47-0
Reproducible in staging?: Y
Reproducible in production?: Not able to test on production
Email or phone of affected tester (no customers): applausetestervd_mweb030424@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal Team

Action Performed:

Pre-requisite: the user must be logged in and have created a Workspace.

  1. Go to Workspace > Bank account.
  2. Tap on Connect with Plaid.
  3. Select Chase bank and use the testing credentials.
  4. Select the account ending with 1111.
  5. Enter "011401533" as the Routing number.
  6. Enter "1111" as Account number.
  7. Verify you can continue the add BA flow.
  8. Reach the double check Company information page.
  9. Tap on "Confirm".
  10. Verify you see an error is displayed.
  11. Tap on "fix the errors".
  12. Verify nothing happens.

Expected Result:

The user should not be able to continue the flow if the account number entered is incomplete or wrong.

Actual Result:

The user is able to continue the flow with incomplete account number, then an error appears on the double check Company information page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6402467_1709625593635.Ojyt1344_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01e89faf072ebd1655
  • Upwork Job ID: 1765013045602160640
  • Last Price Increase: 2024-03-05
@izarutskaya izarutskaya added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@izarutskaya
Copy link
Author

@cristipaval I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

@nkuoch
Copy link
Contributor

nkuoch commented Mar 5, 2024

I'll fix it myself

@cristipaval
Copy link
Contributor

This is reproducible in production as well. Tested with 1.4.46-2

@cristipaval
Copy link
Contributor

Thanks @nkuoch!

@shubham1206agra
Copy link
Contributor

@nkuoch If you want, I can help you here as this is probably coming from VBBA refactor

@cristipaval cristipaval added Daily KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Mar 5, 2024
@nkuoch nkuoch added the Internal Requires API changes or must be handled by Expensify staff label Mar 5, 2024
Copy link

melvin-bot bot commented Mar 5, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01e89faf072ebd1655

Copy link

melvin-bot bot commented Mar 5, 2024

Triggered auto assignment to Contributor Plus for review of internal employee PR - @aimane-chnaif (Internal)

@nkuoch nkuoch added Weekly KSv2 and removed Daily KSv2 labels Mar 5, 2024
@nkuoch
Copy link
Contributor

nkuoch commented Mar 5, 2024

This will be a BE PR, no need for contributor plus

@nkuoch nkuoch added the Reviewing Has a PR in review label Mar 5, 2024
@kadiealexander kadiealexander moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 20, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

This issue has not been updated in over 15 days. @nkuoch, @kadiealexander eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@trjExpensify
Copy link
Contributor

@kadiealexander as a bug that doesn't block the release, I'm moving this to Polish. That said, is the PR done here?

@trjExpensify trjExpensify moved this from Release 1: Spring 2024 (May) to Polish in [#whatsnext] #wave-collect Apr 16, 2024
@kadiealexander
Copy link
Contributor

Yeah it is, weird this didn't close. Closing as complete, thanks @trjExpensify!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Reviewing Has a PR in review
Projects
No open projects
Archived in project
Development

No branches or pull requests

7 participants