[HOLD for payment 2024-03-13] [$125] Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null. #37445
Comments
|
Triggered auto assignment to @kadiealexander ( |
|
We think that this bug might be related to #vip-vsp |
|
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.Room - Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null What is the root cause of that problem?This happens when report.visibility = null, meets this condition: What changes do you think we should make in order to solve the problem?update condition to |
ProposalPlease re-state the problem that we are trying to solve in this issue.Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null What is the root cause of that problem?This happens because when we are offline the visibility is returned as null but we return false only when it is undefined. What changes do you think we should make in order to solve the problem?We need to update the condition to
What alternative solutions did you explore? (Optional)N/A |
|
Job added to Upwork: https://www.upwork.com/jobs/~0122cd4185dcaeff62 |
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Report settings shows Visibility as newRoomPage.visibilityOptions.null What is the root cause of that problem?This condition does not cover the value when it's What changes do you think we should make in order to solve the problem?Let's keep the same "coding standards" to to ensure consistency and maintainability across the codebase. we can then change to: - {report?.visibility != undefined &&
+ {report?.visibility != null &&This condition will be true if report?.visibility is anything other than null or undefined, effectively extending the original check to cover null values as well. What alternative solutions did you explore? (Optional)To ensure the report?.visibility is not undefined, not null, and contains one of the specified values ('restricted', 'private', 'public', 'public_announce'), we can refine the conditional check by using a combination of nullish coalescing and checking if the value exists within your defined object. This way, we're not only checking for the presence of a value but also validating that it's one of the acceptable options. Here's a code snippet: const visibilityOptions = {
restricted: 'Workspace',
private: 'Private',
public: 'Public',
public_announce: 'Public Announce',
};
// Ensuring report?.visibility is defined and matches one of the keys in visibilityOptions
if (report?.visibility && visibilityOptions.hasOwnProperty(report.visibility)) {We have the list of possible values here: Lines 1951 to 1956 in 5cfcf69 This approach uses the |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
|
|
@youssef-lr Thanks for your comment. Yeah, I agree with you about the solution. But I think this issue exists before @tienifr 's recent change, see below video of version 0-RPReplay_Final1709253832.mp4 |
|
Yeah sorry didn't check the code changed, it was there before. I think this is a pretty straightforward change though. So adjusting price accordingly and assigning the first contributor who posted. |
|
Upwork job price has been updated to $125 |
|
📣 @eh2077 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app! |
|
📣 @apeyada You have been assigned to this job! |
|
@apeyada Kindly let us know when we can expect a PR to be ready for review. Thank you! |
|
PR will be ready today |
|
Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
|
|
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-03-13. 🎊 For reference, here are some details about the assignees on this issue:
|
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Checklist
|
|
@kadiealexander this was changed to $125 |
|
Whoops, typo! Updated. @apeyada please let me know when you've accepted the contract I sent across. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 1.4.44-11
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Workspace room settings will not show Visibility row
Actual Result:
Workspace room settings shows Visibility row with newRoomPage.visibilityOptions.null.
This issue only occurs when the workspace room has not been visited
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6395926_1709140787566.20240228_234931.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: