[$500] Hold Request - Approving report that has expenses on hold removes "hold" status

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Found when validating PR : #33897

Version Number: 1.4.43-6
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause-Internal team
Slack conversation:

Action Performed:

precondition: create a workspace, and invite an employee and approver

1. Go to https://staging.new.expensify.com/

2. Log in as an employee

3. Navigate to a workspace chat

4. Create a manual request

5. Submit the report to the approver

6. Navigate to the expense detail page in the submitted report

7. Click on 3 dots > Hold request

8. Enter a reason and hold request

9. In incognito, login in ND as the approver

10. Approve the submitted report

Expected Result:

The report is approved and the system message is added, the expense is still on hold

Actual Result:

The expense status "Hold" is removed, and the system message says that the " unheld this money request"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6386910_1708523131082.Recording__224.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e61187168c0a96ba
• Upwork Job ID: 1760303385679118336
• Last Price Increase: 2024-02-21

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01e61187168c0a96ba

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @iwiznia (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[sakluger]

This is related to our newly released Hold Requests feature (https://github.com/Expensify/Expensify/issues/274076) which is part of Wave 7.

[BartoszGrajdek]

This is the expected behavior right now - it will be handled better after we finish this issue