[PAID] [$500] Video - Two different crashes occur when downloading video

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.43-0
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to any chat.
3. Upload a video.
4. Without playing the video, tap 3-dot menu > Download.
5. Tap Refresh.
6. Upload a video.
7. Play the videp.
8. While the video is playing, tap 3-dot menu > Download.

Expected Result:

In Step 4 and 8, video will be downloaded successfully.

Actual Result:

In Step 4 and 8, different kind of crash occurs when downloading the video.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385234_1708401514169.Screen_Recording_20240220_100945_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0123abf5d159d1b988
• Upwork Job ID: 1759796028263505920
• Last Price Increase: 2024-02-20
• Automatic offers:
• shahinyan11 | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0123abf5d159d1b988

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

we think this bug might be related to #vip-vsb
cc @quinthar

[melvin-bot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[habasefa]

Proposal

Please re-state the problem that we are trying to solve in this issue

Crashes occur when downloading video from preview

What is the root cause of that problem?

Downloading a video from preview, a video not uploaded yet.

What changes do you think we should make in order to solve the problem?

We should remove the download button, just like in pdf preview

App/src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

Lines 33 to 41 in a8b47ea

	const menuItems = useMemo(
	() => [
	{
	icon: Expensicons.Download,
	text: translate('common.download'),
	onSelected: () => {
	downloadAttachment();
	},
	},

What alternative solutions did you explore? (Optional)

[MariaHCD]

This looks related to #30829

cc: @Skalakid @francoisl @akinwale

[shahinyan11]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Video - Two different crashes occur when downloading video

What is the root cause of that problem?

Here the download function uses currentVideoPlayerRef from usePlaybackContext() .
And now the currentVideoPlayerRef is null until the video is playing. It is because here the shareVideoPlayerElements should be called to set currentVideoPlayerRef in VideoPlayerContexts.
But it is not called due to above condition url !== currentlyPlayingURL. The url is preview url but the currentlyPlayingURL is null until the video is playing

What changes do you think we should make in order to solve the problem?

And add below useEffect here

useEffect(() => {
    currentVideoPlayerRef.current = videoPlayerRef.current;
}, [url]);

What alternative solutions did you explore? (Optional)

Remove download code from default menuItems and add it only when the currentVideoPlayerRef.current exists

    const menuItems = useMemo(
        () => [
                {
                    icon: Expensicons.Meter,
                    text: translate('videoPlayer.playbackSpeed'),
                    subMenuItems: [
                        ..._.map(CONST.VIDEO_PLAYER.PLAYBACK_SPEEDS, (speed) => ({
                            icon: currentPlaybackSpeed === speed ? Expensicons.Checkmark : null,
                            text: speed.toString(),
                            onSelected: () => {
                                updatePlaybackSpeed(speed);
                            },
                            shouldPutLeftPaddingWhenNoIcon: true,
                        })),
                    ],
                },
            ],
        [currentVideoPlayerRef, currentPlaybackSpeed, downloadAttachment, translate, updatePlaybackSpeed],
    );

    if(currentVideoPlayerRef.current && menuItems.length < 2){
        menuItems.unshift({
            icon: Expensicons.Download,
            text: translate('common.download'),
            onSelected: () => {
                downloadAttachment();
            },
        })
    }

What alternative solutions did you explore? (Optional)

I don’t know why this url !== currentlyPlayingURL check is used there to say whether it is worth deleting it altogether?
No if it should not be deleted it we can change this condition with one of below options

1. if (shouldUseSharedVideoElement || !url)
2. if (shouldUseSharedVideoElement || (currentlyPlayingURL && url !== currentlyPlayingURL))

But with these changes, the video will play automatically after uploading and If we do not like this approach we can choose below option

[MariaHCD]

@eVoloshchak What do you think of the proposals so far?

[MariaHCD]

From this: https://expensify.slack.com/archives/C01GTK53T8Q/p1708443654362909?thread_ts=1708443084.946829&cid=C01GTK53T8Q

I think these will be assigned to @Skalakid

[francoisl]

@Habtamu-Asefa I think your proposal is incomplete, it would remove the download button even when playing a video that's already been uploaded. Also, the same crash happens when changing the playback speed, and while it would make sense to remove the download button for a video that hasn't been uploaded yet, we probably want to keep the playback speed option while previewing videos before uploading them.

@shahinyan11 your solution fixes the crashes for me locally, though in your second useEffect() it looks like setCurrentVideoPlayerRef and videoPlayerRef are missing as dependencies, right?

[shahinyan11]

@shahinyan11 your solution fixes the crashes for me locally, though in your second useEffect() it looks like setCurrentVideoPlayerRef and videoPlayerRef are missing as dependencies, right?

@francoisl No sense to use ref value in dependencies . It doesn't affect anything . Are you agree ?

[francoisl]

Maybe but that's an ESLint rule, you can try locally and I'm pretty sure the linter will give you a warning.

Other question: the currentVideoPlayerRef.current is already being set in the shareVideoPlayerElements useCallback, can we remove it from there?

[puneetlath]

Removing the deploy blocker label. Doesn't seem like this is a staging-only issue.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• FIx downloading video crash #37122

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @shahinyan11 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@shahinyan11 - I've paid you via Upwork and closed the contract.

@eVoloshchak - I'll post the payment summary for your manual request once the checklist is done.

Thanks!

[aimane-chnaif]

Note: there was another crash regression from this issue - https://github.com/Expensify/App/pull/37122/files#r1525005774.
I suggest not to apply penalty since it's tough one and video player feature has still lots of minor small bugs.

[strepanier03]

Thank you @aimane-chnaif for the update and the context into the penalty. Unless someone disagrees I'll go with your recommendation.

[strepanier03]

@eVoloshchak - Checklist when you get a chance please!

[melvin-bot]

@francoisl, @eVoloshchak, @strepanier03, @shahinyan11 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Video player #30829
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/30829/files#r1529495802
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this was an edge case missed during implementation of a major feature

Regression Test Proposal

1. Go to any chat.
2. Click + button -> Add Attachment -> select any video
3. Tap 3-dot menu and make sure there is no Download action

Do we agree 👍 or 👎

[strepanier03]

https://github.com/Expensify/Expensify/issues/380534

[strepanier03]

Payment summary

• @eVoloshchak - $500 via Manual Requests
• @shahinyan11 - $500 via Upwork - PAID

@JmillsExpensify incoming payment request from @eVoloshchak.

[JmillsExpensify]

$500 approved for @eVoloshchak based on summary.