Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-02-15] Fix broken updateHelpDotRedirects.yml action build #35954

Closed
blimpich opened this issue Feb 6, 2024 · 4 comments
Assignees

Comments

@blimpich
Copy link
Contributor

blimpich commented Feb 6, 2024

Problem

Our updateHelpDotRedirects.yml action is failing https://github.com/Expensify/App/actions/runs/7805376055 due to having fragments in the redirect urls.

Solution

Remove the fragments.

cc: @nkuoch @caitlinwhite1

@blimpich blimpich self-assigned this Feb 6, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 6, 2024
@blimpich blimpich added Daily KSv2 and removed Weekly KSv2 labels Feb 6, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Feb 8, 2024
@melvin-bot melvin-bot bot changed the title Fix broken updateHelpDotRedirects.yml action build [HOLD for payment 2024-02-15] Fix broken updateHelpDotRedirects.yml action build Feb 8, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 8, 2024
Copy link

melvin-bot bot commented Feb 8, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 8, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.38-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-02-15. 🎊

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Feb 15, 2024
Copy link

melvin-bot bot commented Feb 15, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@blimpich blimpich removed the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 15, 2024
@blimpich
Copy link
Contributor Author

This can be closed, fix was merged in awhile back. I thought melvin would auto-close it.

@melvin-bot melvin-bot bot removed the Overdue label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant