[HOLD for payment 2024-03-13] [$500] mWeb - Welcome to Expensify is shown for existing user after logging in from public room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.34-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause -Internal Team
Slack conversation:

Action Performed:

1. Log out of New Expensify
2. Navigate to this link - https://staging.new.expensify.com/r/5408450846930023
3. Click on Sign In
4. Login in with an existing account

Expected Result:

Public room chat history should be displayed.
Welcome to Expensify message should be either shown before logging in or not at all for existing users

Actual Result:

Welcome to Expensify screen is shown after log in, user is forced to close it to view public room chat history

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6362919_1706736644415.Record_2024-01-31-20-50-10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01adefc3ca63c114f2
• Upwork Job ID: 1752868613105299456
• Last Price Increase: 2024-02-15
• Automatic offers:
• situchan | Contributor | 0

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01adefc3ca63c114f2

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[lanitochka17]

We think that this bug might be related to #vip-vsp
CC @quinthar

[aswin-s]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Engagement modal is shown while visiting a public room via deep link as an anonymous user.

What is the root cause of that problem?

The check for showing engagement model is performed inside BottomTabBar in a useEffect.

App/src/libs/Navigation/AppNavigator/createCustomBottomTabNavigator/BottomTabBar.tsx

Line 55 in 3e77445

Welcome.show(routes, () => Navigation.navigate(ROUTES.ONBOARD));

Inside Welcome.show method, the engamement modal is shown if current user is isFirstTimeNewExpensifyUser.

App/src/libs/actions/Welcome.ts

Lines 130 to 132 in 3e77445

	if (!isFirstTimeNewExpensifyUser) {
	return;
	}

App/src/libs/actions/Welcome.ts

Lines 171 to 173 in 3e77445

	if (!Policy.isAdminOfFreePolicy(allPolicies ?? undefined) && !isExitingToWorkspaceRoute && !hasSelectedChoice && !hasDismissedModal && Object.keys(allPolicies ?? {}).length === 1) {
	showEngagementModal();
	}

However the above check doesn't consider whether the current user is an anonymous user. That's why the engagement modal gets shown for anonymous user.

What changes do you think we should make in order to solve the problem?

Check if current user is an anonymous user before showing engagement modal.

// Add check for anonymous user
if (!Session.isAnonymousUser() && !Policy.isAdminOfFreePolicy(allPolicies ?? undefined) && !isExitingToWorkspaceRoute && !hasSelectedChoice && !hasDismissedModal && Object.keys(allPolicies ?? {}).length === 1) {
  showEngagementModal();
}

What alternative solutions did you explore? (Optional)

None

[sakluger]

I asked in #vip-vsb if this is a bug or expected behavior: https://expensify.slack.com/archives/C066HJM2CAZ/p1707178252015419

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@sakluger, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Santhosh-Sellavel]

I asked in #vip-vsb if this is a bug or expected behavior: https://expensify.slack.com/archives/C066HJM2CAZ/p1707178252015419

Any update @sakluger

[melvin-bot]

@sakluger, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

[sakluger]

Yes, sorry for the delay. This is confirmed as a bug - we should only show the welcome message to new users.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Santhosh-Sellavel]

@sakluger Seems the issue is not reproducible, if any C+ assistance please reassign it, thanks!
Unassigning due to low bandwidth as am planning for OOO

[situchan]

I can take over since I already have context while reviewing original PR of this new feature

---

I am not able to reproduce on Step 4 (after sign in).

But instead I am seeing welcome page on Step 2 (after deep link). Is this expected or bug? I believe bug

Screen.Recording.2024-02-14.at.4.03.12.AM.mov

[melvin-bot]

@sakluger this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[situchan]

@luacmartins
Bug not reproducible on Step 4 (after sign in) which was OP.
But instead seeing welcome page on Step 2 (after deep link). This is the bug to fix.

[melvin-bot]

@sakluger @luacmartins @situchan this issue is now 4 weeks old and preventing us from maintaining WAQ, can you:

• Decide whether any proposals currently meet our guidelines and can be approved as-is today
• If no proposals meet that standard, please take this issue internal and treat it as one of your highest priorities
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.47-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: disable engagement modal display for anonymous users #37673

If no regressions arise, payment will be issued on 2024-03-13. 🎊

For reference, here are some details about the assignees on this issue:

• @aswin-s requires payment (Needs manual offer from BZ)
• @situchan requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sakluger]

Summarizing payment on this issue:

Contributor: @aswin-s $500, sent offer via Upwork (https://www.upwork.com/nx/wm/offer/101367608/)
Contributor+: @situchan $500, paid via Upwork

@situchan could you please complete the BZ checklist?

[situchan]

This was missing test case from new feature of engagement modal. Not regression.

Regression Test Proposal

1. Logout if already logged in
2. Navigate to this link - https://staging.new.expensify.com/r/5408450846930023
3. Wait for the page to load completely
4. Verify that engagement modal is not shown for anonymous user
5. Login in with an existing account
6. Wait for the page to load completely
7. Verify that engagement modal is not shown

[sakluger]

Thanks! I paid out all the offers and created the regression test issue.