[HOLD for payment 2024-01-31] [$500] Mention - Only 3 user are scrollable when use keyboard to pick user to mention

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.17-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal
Slack conversation:

Action Performed:

Precondition:
Connect the pc keyboard to mobile device
Steps:

1. Navigate to staging.new.expensify.com
2. Go to any chat
3. Start texting until chat is expanded
4. Type @ to open mention member list
5. Use keyboard arrows to scroll through the list

Expected Result:

User should be able to navigate to all members in the list

Actual Result:

When using keyboard arrows user is able to scroll only 3 members from the list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6326341_1703616195297.Recording__1643.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017bdddeb3dc37e5c7
• Upwork Job ID: 1739721691952898048
• Last Price Increase: 2024-01-09
• Automatic offers:
• mkhutornyi | Contributor | 28095701

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017bdddeb3dc37e5c7

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Mention - Only 3 user are scrollable when use keyboard to pick user to mention
This happens on emoji suggestion as well

What is the root cause of that problem?

App/src/libs/SuggestionUtils.js

Line 9 in 64a88e4

function getMaxArrowIndex(numRows, isAutoSuggestionPickerLarge) {

Here, we're getting max arrow index from 2 factors: list size and isAutoSuggestionPickerLarge
So if isAutoSuggestionPickerLarge = false and list size > 3, this function always returns 3, ignoring list size. And this sets maxIndex of arrow focus manager to 3.

What changes do you think we should make in order to solve the problem?

arrow max index should not depend on visible size as it's scrollable
So replace this line with maxIndex: suggestionValues.suggestedMentions.length - 1

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 62 in 64a88e4

maxIndex: SuggestionsUtils.getMaxArrowIndex(suggestionValues.suggestedMentions.length, isAutoSuggestionPickerLarge),

Same applies to SuggestionEmoji

[rrrshtt]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Suggestions stacked in 3 items with keyboard control.

What is the root cause of that problem?

App/src/libs/SuggestionUtils.js

Line 9 in 2b58e1c

function getMaxArrowIndex(numRows, isAutoSuggestionPickerLarge) {

App/src/pages/home/report/ReportActionCompose/SuggestionMention.js

Line 62 in 2b58e1c

maxIndex: SuggestionsUtils.getMaxArrowIndex(suggestionValues.suggestedMentions.length, isAutoSuggestionPickerLarge),

The entire function getMaxArrowIndex() is incorrect for this purpose since it's a keyboard controller.

What changes do you think we should make in order to solve the problem?

We can simply use the length of suggested mentions in the keyboard controller because we only need the total number of items in the hook.

[melvin-bot]

📣 @rrrshtt! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[rrrshtt]

Contributor details
Your Expensify account email: mrishat03@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~012f657c01285b6cf0

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[bfitzexpensify]

Couple of proposals ready for review, thanks @eVoloshchak

[melvin-bot]

@eVoloshchak, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[bfitzexpensify]

Assuming @eVoloshchak was off for the holidays, this isn't an urgent issue

[melvin-bot]

@eVoloshchak, @bfitzexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bfitzexpensify]

@eVoloshchak this one is ready for proposal review - thank you

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@eVoloshchak @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[bfitzexpensify]

Bump here @eVoloshchak

[CortneyOfstad]

@mkhutornyi Any updates? Thanks!

[mkhutornyi]

I will raise PR by eod

[mkhutornyi]

PR is ready for review

[CortneyOfstad]

@eVoloshchak any update on the PR above^^^ thanks!

[eVoloshchak]

PR has been merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.30-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix keyboard arrow maxIndex in emoji/mention suggestion #34554

If no regressions arise, payment will be issued on 2024-01-31. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @mkhutornyi requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@eVoloshchak] The PR that introduced the bug has been identified. Link to the PR:
• [@eVoloshchak] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@eVoloshchak] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@eVoloshchak] Determine if we should create a regression test for this bug.
• [@eVoloshchak] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@CortneyOfstad / @bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[CortneyOfstad]

Payment Summary

@mkhutornyi (Contributor) — paid $500 via Upwork
@eVoloshchak (C+) — to be paid $500 via New Dot

[CortneyOfstad]

@eVoloshchak any update on the checklist above? Thanks!

[CortneyOfstad]

@eVoloshchak just bumping on the checklist so we can get this closed. Thanks!

[eVoloshchak]

• The PR that introduced the bug has been identified. Link to the PR: Performance: chat input #25758
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/25758/files#r1477093662
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think an additional discussion is needed, this is a very minor bug
• Determine if we should create a regression test for this bug.
  Is it easy to test for this bug? No, this requires an Android device with a physical keyboard connected to test
  Is the bug related to an important user flow? No
  Is it an impactful bug? No
  We don't need a regression test here, the bug is rare and isn't impactful, and it might be hard for QA to test

[eVoloshchak]

Requested the payment

[JmillsExpensify]

$500 approved for @eVoloshchak based on summary above.

[CortneyOfstad]

Thanks all!