[HOLD for payment 2023-12-08] [HOLD for payment 2023-12-07] Contact method - App crashes when removing secondary contact method

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 1.4.5-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Launch New Expensify app.
2. Go to Settings > Profile > Contact methods.
3. Go to Contact methods > New contact method.
4. Add a new contact method and save.
5. Tap on the new contact.
6. Remove the new contact method.

Expected Result:

App does not crash.

Actual Result:

App crashes.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari -console error
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6294671_1701266891730.Screen_Recording_20231129_210452_One_UI_Home.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ZhenjaHorbach]

#28711
The problem is related to this PR

Proposal

Please re-state the problem that we are trying to solve in this issue.

Contact method - App crashes when removing secondary contact method

What is the root cause of that problem?

It looks like when this code is executed, validateCodeFormRef is not available and is equal null
As a result, we turn to a non-existent method

What changes do you think we should make in order to solve the problem?

We can update code like

                        onModalHide={() => {
                            InteractionManager.runAfterInteractions(() => {
                                this.validateCodeFormRef.current && this.validateCodeFormRef.current.focusLastSelected();
                            });
                        }}

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Lines 267 to 271 in 2f9ae2d

	onModalHide={() => {
	InteractionManager.runAfterInteractions(() => {
	this.validateCodeFormRef.current.focusLastSelected();
	});
	}}

Like here

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.js

Line 255 in 2f9ae2d

onEntryTransitionEnd={() => this.validateCodeFormRef.current && this.validateCodeFormRef.current.focus()}

What alternative solutions did you explore? (Optional)

NA

[dangrous]

Ah, from a PR I reviewed I think. Working on a quick fix

[dangrous]

PR has been merged, requested a CP

[dangrous]

This is confirmed fixed on staging! I believe regressions are not paid out, is that correct @situchan? If so I will go ahead and close this.

[situchan]

I believe regressions are not paid out

yes correct if regression fixed by offending PR author/reviewer.
I am not involved in original issue / PR so I am still eligible

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.5-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix contact method crash #32193

If no regressions arise, payment will be issued on 2023-12-07. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[dangrous]

Ah my bad, misread the GH handle! I'll get a BZ for this one.

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dangrous]

No action right now @garrettmknight, just assigning a BZ for @situchan's review payment once it's time.

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix contact method crash #32193

If no regressions arise, payment will be issued on 2023-12-08. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@dangrous] The PR that introduced the bug has been identified. Link to the PR: Magic code blur #28711
• [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Magic code blur #28711 (comment)
• [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1701459605232009
• [@dangrous] Determine if we should create a regression test for this bug. No, it was already caught during regression testing.
• [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A
• [@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dangrous]

Checklist updated for when we're ready

Upwork Job for my ref: https://www.upwork.com/en-gb/ab/applicants/1733182767793901568/job-details

[garrettmknight]

@situchan offer out to you - I'll pay when you accept

[garrettmknight]

Paid - closing!