[HOLD for payment 2023-12-20] [$250][Cleanup] Always use constants for screen names

[roryabraham]

Coming from #31543 (comment)...

Problem

We have two patterns for adding screens in E/App, and we aren't consistent about when a constant should be used for a screen name in SCREENS.ts or not. This leads to unnecessary confusion and inconsistency. The developer has to decide which pattern to follow, and if a constant needs to be added must adjust the navigation stack accordingly in a PR that does not add a new screen.

Solution

Let's clean this up to always use constants for screen names in E/App (from SCREENS.ts).

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fe00e0d9ee39b022
• Upwork Job ID: 1729552664025485312
• Last Price Increase: 2023-11-28
• Automatic offers:
• cubuspl42 | Reviewer | 27871796

[roryabraham]

Marking this as external but not help wanted as @blazejkustra is going to work on this.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fe00e0d9ee39b022

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[melvin-bot]

Triggered auto assignment to @puneetlath (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Upwork job price has been updated to $250

[roryabraham]

Adjusting the C+ review payment for this from $500 to $250

[blazejkustra]

Hey! I’m Blazej from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

📣 @cubuspl42 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[blazejkustra]

@cubuspl42 @roryabraham PR is ready for review, I didn't post a proposal as this was pretty straight forward change.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.11-25 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [No QA][Cleanup] Always use constants for screen names #32430

If no regressions arise, payment will be issued on 2023-12-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Reviewer)
• @blazejkustra does not require payment (Contractor)

[cubuspl42]

@puneetlath Do we need to assign someone to process the payment?

[puneetlath]

Whoops, I got it. All paid!