Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-12-29] [TS migration] Migrate 'MoneyReportHeaderStatusBar.js' component to TypeScript #31943

Closed
melvin-bot bot opened this issue Nov 27, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Nov 27, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/components/MoneyReportHeaderStatusBar.js 8
@pasyukevich
Copy link
Member

Hi,
I'm Eugene from Callstack - an expert contributor group
I’d like to work on this issue

Copy link
Author

melvin-bot bot commented Dec 17, 2023

Triggered auto assignment to @srikarparsi, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@hoangzinh
Copy link
Contributor

hi @srikarparsi , can you help to:

  1. Assign me to this issue
  2. Add the issue label "New Feature" or "Bug" to trigger adding a BZ member to this issue
    Thanks

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Dec 22, 2023
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'MoneyReportHeaderStatusBar.js' component to TypeScript [HOLD for payment 2023-12-29] [TS migration] Migrate 'MoneyReportHeaderStatusBar.js' component to TypeScript Dec 22, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Dec 22, 2023
Copy link
Author

melvin-bot bot commented Dec 22, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Dec 22, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.15-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-12-29. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Dec 28, 2023
Copy link
Author

melvin-bot bot commented Jan 2, 2024

@srikarparsi Huh... This is 4 days overdue. Who can take care of this?

@hoangzinh
Copy link
Contributor

Hi @srikarparsi can you help to assign me to this issue and do payment here? Thanks. I reviewed the PR #32655

@srikarparsi
Copy link
Contributor

yes, sorry for missing your last message

@melvin-bot melvin-bot bot removed the Overdue label Jan 3, 2024
@srikarparsi srikarparsi added the Bug Something is broken. Auto assigns a BugZero manager. label Jan 3, 2024
Copy link
Author

melvin-bot bot commented Jan 3, 2024

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

Copy link
Author

melvin-bot bot commented Jan 3, 2024

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@srikarparsi
Copy link
Contributor

Hey @stephanieelliott! Do you think you could help pay $250 for reviewing a TS Migration PR to @hoangzinh whenever you have a chance?

@stephanieelliott
Copy link
Contributor

Can do! @hoangzinh I've invited you to the job on Upwork, can you accept when you get a chance please?

Upwork job is here: https://www.upwork.com/jobs/~01576d1452ee419762

@hoangzinh
Copy link
Contributor

Accepted. Thanks @stephanieelliott

@stephanieelliott
Copy link
Contributor

All paid! Summarizing payment on this issue:

  • Contributor: N/A
  • Contributor+: @hoangzinh, paid $250 via Upwork

Upwork job is here: https://www.upwork.com/jobs/~01576d1452ee419762

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Task Typescript Migration
Projects
No open projects
Development

No branches or pull requests

4 participants