[HOLD for payment 2024-04-05] [$500] [MEDIUM] Expensify Cards: Transactions - Update Generic Receipts to use ReceiptBackground

[grgia]

All details needed are below, so no worries if you can't access this!

Overview

Currently for Scan Receipt, we have a few options of png previews for different file types. We need to replace these with the new ReceiptBackground component. Basically, it should be relatively simple, replacing the existing thumbnail with EReceiptThumbnail

We'll also need to update the component to support a label like the existing images - e.g. HTML, PDF, etc.

Design Doc

### Design Doc Section https://docs.google.com/document/d/1iELOXPOAcnuIPZJ3XbO1S8_3qHaM31Ptf8dR4LRZMyE/edit#bookmark=kix.xnc4hi7wlvbg 

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d3d6d9c663db1e73
• Upwork Job ID: 1709590683807113216
• Last Price Increase: 2024-01-09
• Automatic offers:
• mollfpr | Contributor | 28092661
• FitseTLT | Contributor | 28097509

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d3d6d9c663db1e73

[melvin-bot]

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

[melvin-bot]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[grgia]

not overdue, this is just clean up and can be de-prioritized for now

[zanyrenney]

What is it being de-priotised in favour of? Should we not finish it off?

If it should be de-prioritised @grgia please can you update the labels to reflect the cadence it should be worked on? e.g. change this to Monthly / put it on "hold"

[grgia]

@zanyrenney weekly is the correct label

[zanyrenney]

any further update here @grgia ?

[grgia]

Adding monthly for now

[FitseTLT]

Here is how it looks after the label is added

[shawnborton]

That feels pretty good to me, curious if others agree though!

[dannymcclain]

Yup—looks pretty solid to me too!

[dangrous]

How are we looking on this one? Do we think we'll be able to final review and merge sometime this week? Thanks!

[mollfpr]

@dangrous I just finished reviewing and testing. It looks good to me!

[FitseTLT]

Only one doubt I have @dangrous is EReceiptThumnail sets its bg color dynamically based on the transaction id so it might cause some confusions, for instance, when we create a request because it is a draft transaction (with transactionID 1) on confirmation page it will always be orange and after you create the request it will have different bg color when it gets its real transaction id. So should we set static bg color or we can go with the current dynamic bg color status ???

[dangrous]

Eh, I think it'll be fine - I'm not that concerned about that for now.

I will have time to look through the PR tomorrow morning! Looking forward to it.

[melvin-bot]

This issue has not been updated in over 15 days. @dangrous, @mollfpr, @FitseTLT, @zanyrenney eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Transactions - Update Generic Receipts to use ReceiptBackground #34843

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

• @mollfpr requires payment automatic offer (Contributor)
• @FitseTLT requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@zanyrenney] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[zanyrenney]

payment summary

@mollfpr requires payment automatic offer (Contributor)
@FitseTLT requires payment automatic offer (Contributor)- paid $500

[mollfpr]

[@mollfpr] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.

I don't think we need a regression test here.

@zanyrenney I'll do manual request in NewDot, thank you!

[zanyrenney]

payment summary

@mollfpr requires payment automatic offer (Contributor) to be paid $500 on ND.
@FitseTLT requires payment automatic offer (Contributor)- paid $500

[JmillsExpensify]

$500 approved for @mollfpr