Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1000] Web - Girl with earings default avatar glitches when coming back from share code #25602

Closed
1 of 6 tasks
izarutskaya opened this issue Aug 21, 2023 · 20 comments
Closed
1 of 6 tasks
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors

Comments

@izarutskaya
Copy link

izarutskaya commented Aug 21, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open the app
  2. Create group with user which has 'girl with earings' default avatar
  3. Visit shareCode page by deep link, link: https://staging.new.expensify.com/settings/shareCode
  4. Click on back and observe the avatar in group, it will be blacked out

Expected Result:

Default avatars should not change color when visiting different pages

Actual Result:

Girl with earings default avatar turns fully black when we visit shareCode page by deeplink and come back to settings page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: v1.3.55-7

Reproducible in staging?: Y

Reproducible in production?: N

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

blacked.out.avatar.mp4
Recording.5959.mp4

Expensify/Expensify Issue URL:

Issue reported by: @dhanashree-sawant

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1691648410032539

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01f62a96abd1e374f5
  • Upwork Job ID: 1694034176852705280
  • Last Price Increase: 2023-08-29
@izarutskaya izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@izarutskaya izarutskaya added the DeployBlockerCash This issue or pull request should block deployment label Aug 21, 2023
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 21, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mvtglobally
Copy link

This has been repro in older builds and for some reason not repro in prod now. We added a Blocker label, but not sure if it's really a blocker

@mountiny @roryabraham since you are on checklist this week.

@0xmiros
Copy link
Contributor

0xmiros commented Aug 21, 2023

I first reported similar issue - https://expensify.slack.com/archives/C049HHMV9SM/p1682539730049199

@CortneyOfstad
Copy link
Contributor

Bump @puneetlath @roryabraham @mountiny Do we feel like this is an actual blocker?

@roryabraham
Copy link
Contributor

Definitely not going to treat this as a deploy blocker. Let's verify that it can be reproduced then make it external with a lower bounty amount of $500. Thanks!

@roryabraham roryabraham added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Aug 21, 2023
@dhanashree-sawant
Copy link

Hi @0xmiroslav, although similar, that issue is not recreatable with your steps now and avatar too is different. Not sure if same root cause but I believe current issue reproduction steps are consistent and helped us to understand the issue properly.

@puneetlath puneetlath added the External Added to denote the issue can be worked on by a contributor label Aug 22, 2023
@melvin-bot melvin-bot bot changed the title Web - Girl with earings default avatar glitches when coming back from share code [$1000] Web - Girl with earings default avatar glitches when coming back from share code Aug 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01f62a96abd1e374f5

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 22, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Current assignees @puneetlath and @CortneyOfstad are eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented Aug 22, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

@melvin-bot melvin-bot bot added the Overdue label Aug 24, 2023
@CortneyOfstad
Copy link
Contributor

still waiting on proposals, so not overdue 👍

@melvin-bot melvin-bot bot removed the Overdue label Aug 24, 2023
@WikusKriek
Copy link
Contributor

Not able to replicate this.

@melvin-bot melvin-bot bot added the Overdue label Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 28, 2023

@puneetlath, @eVoloshchak, @CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@CortneyOfstad
Copy link
Contributor

@eVoloshchak @puneetlath Are either of you able to reproduce this? I'm not able to

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@puneetlath
Copy link
Contributor

Hm, me either.

@melvin-bot melvin-bot bot added the Overdue label Sep 1, 2023
@CortneyOfstad
Copy link
Contributor

Okay, I'm going to close this. If this pops up again, feel free to reopen the GH and we can re-address 👍

@melvin-bot melvin-bot bot removed the Overdue label Sep 1, 2023
@dhanashree-sawant
Copy link

I couldn't find that avatar anymore, did we decide to remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors
Projects
None yet
Development

No branches or pull requests

10 participants