Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workspace - Newly created workspace does not appear in workspace list on second device #25423

Closed
2 of 6 tasks
lanitochka17 opened this issue Aug 17, 2023 · 9 comments
Closed
2 of 6 tasks
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 17, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to staging.new.expensify.com with the same account on two devices
  2. On the first device, create a new workspace
  3. On the second device, go to Settings > Workspace

Expected Result:

The newly created workspace will appear on the second device

Actual Result:

The chat room for the newly created workspace appear on LHN on the second device, but not on the workspace list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • Windows / Chrome
  • MacOS / Desktop

Version Number: 1.3.55-2

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6168456_bandicam_2023-08-18_01-59-06-122.1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Aug 17, 2023
@github-actions github-actions bot added the Hourly KSv2 label Aug 17, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

Triggered auto assignment to @puneetlath (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@dummy-1111
Copy link
Contributor

This issue is the regression of this PR.

When we create a workspace, we optimistically set isPolicyExpenseChatEnabled: true but the pusher events doesn't include this value.

This is the root cause
We can revert the PR but I think this should be fixed in the backend

@Nikhil-Vats

This comment was marked as outdated.

@dummy-1111
Copy link
Contributor

@Nikhil-Vats

Did you pull the latest changes? It's still reproducible for me on main

@Nikhil-Vats
Copy link
Contributor

oh okay, thanks for the update.

@yuwenmemon yuwenmemon removed the DeployBlockerCash This issue or pull request should block deployment label Aug 17, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 21, 2023
@puneetlath puneetlath added Daily KSv2 and removed Hourly KSv2 labels Aug 21, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 21, 2023
@puneetlath
Copy link
Contributor

Assigning over to @youssef-lr since he already has a PR up for this.

@puneetlath puneetlath assigned youssef-lr and unassigned puneetlath Aug 21, 2023
@youssef-lr youssef-lr added the Reviewing Has a PR in review label Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 29, 2023

@youssef-lr Whoops! This issue is 2 days overdue. Let's get this updated quick!

@youssef-lr
Copy link
Contributor

This has been deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants