-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-03-20] [$250] [TS migration] Migrate 'Report' page to TypeScript #25216
Comments
This issue has not been updated in over 15 days. eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing. If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead. |
Please remove a comment from the file src/libs/Navigation/AppNavigator/ReportScreenWrapper.tsx after the |
Dibs |
Job added to Upwork: https://www.upwork.com/jobs/~0114b762fd93bf8075 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws ( |
Sounds great! thanks |
Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-03-20. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Apologies, I was OOO last week. Taking a look at this now! |
I might be eligible as well for reviewing 2nd PR which fixes regression |
Sending an offer to @aimane-chnaif and @Ollyws for this job (and both PRs) |
Accepted, thanks. |
Hey @Ollyws - hmm, my dashboard in upwork still says it's waiting for you to accept 🤔 Can you show me what you see? |
Oh, nevermind, I am stupid - I sent two offers to you instead of one to each of you. I will remove this one and send a new one to @aimane-chnaif |
Okay, fixed! |
TypeScript migration
Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.
Files
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @greg-schroederThe text was updated successfully, but these errors were encountered: