Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-03-20] [$250] [TS migration] Migrate 'Report' page to TypeScript #25216

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 34 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
src/pages/home/ReportScreen.js 39
src/pages/home/HeaderView.js 32
src/pages/home/report/ReportFooter.js 19
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0114b762fd93bf8075
  • Upwork Job ID: 1750847526992384000
  • Last Price Increase: 2024-01-26
  • Automatic offers:
    • Ollyws | Reviewer | 28123507
Issue OwnerCurrent Issue Owner: @greg-schroeder
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Typescript migration Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@roryabraham roryabraham moved this from Done to Todo in Typescript migration Nov 29, 2023
@VickyStash
Copy link
Contributor

Please remove a comment from the file src/libs/Navigation/AppNavigator/ReportScreenWrapper.tsx after the ReportScreen page is migrated to TypeScript.

@ghost
Copy link

ghost commented Jan 26, 2024

Dibs

@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 26, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'Report' page to TypeScript [$500] [TS migration] Migrate 'Report' page to TypeScript Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0114b762fd93bf8075

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Jan 26, 2024
Copy link
Author

melvin-bot bot commented Jan 26, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Monthly KSv2 labels Jan 26, 2024
@mountiny mountiny added NewFeature Something to build that is a new item. and removed Task labels Jan 26, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Feb 27, 2024
@greg-schroeder
Copy link
Contributor

Sounds great! thanks

Copy link
Author

melvin-bot bot commented Mar 4, 2024

Triggered auto assignment to @puneetlath, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Mar 12, 2024
Copy link
Author

melvin-bot bot commented Mar 12, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 13, 2024
@melvin-bot melvin-bot bot changed the title [$250] [TS migration] Migrate 'Report' page to TypeScript [HOLD for payment 2024-03-20] [$250] [TS migration] Migrate 'Report' page to TypeScript Mar 13, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Mar 13, 2024
Copy link
Author

melvin-bot bot commented Mar 13, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Mar 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.51-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-03-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Mar 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@Ollyws] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Mar 20, 2024
@greg-schroeder
Copy link
Contributor

Apologies, I was OOO last week. Taking a look at this now!

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@aimane-chnaif
Copy link
Contributor

I might be eligible as well for reviewing 2nd PR which fixes regression

@greg-schroeder
Copy link
Contributor

Sending an offer to @aimane-chnaif and @Ollyws for this job (and both PRs)

@Ollyws
Copy link
Contributor

Ollyws commented Mar 25, 2024

Accepted, thanks.

@greg-schroeder
Copy link
Contributor

Hey @Ollyws - hmm, my dashboard in upwork still says it's waiting for you to accept 🤔

Can you show me what you see?

@greg-schroeder
Copy link
Contributor

Oh, nevermind, I am stupid - I sent two offers to you instead of one to each of you. I will remove this one and send a new one to @aimane-chnaif

@greg-schroeder
Copy link
Contributor

Okay, fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item. Typescript Migration
Projects
No open projects
Development

No branches or pull requests

8 participants